Revert JuliaSyntax v1 compatibility changes - incompatible with v0.4.10#969
Draft
Revert JuliaSyntax v1 compatibility changes - incompatible with v0.4.10#969
Conversation
Co-authored-by: domluna <1907223+domluna@users.noreply.github.com>
Co-authored-by: domluna <1907223+domluna@users.noreply.github.com>
Co-authored-by: domluna <1907223+domluna@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Continue work on dl/js-v1 branch to pass all tests
Fix JuliaSyntax v1 compatibility: API changes and operator detection
Feb 7, 2026
Collaborator
|
@copilot ughhh |
Co-authored-by: domluna <1907223+domluna@users.noreply.github.com>
Contributor
Author
Reverted all changes in a82c0d0. The issue was making JuliaSyntax v1 compatibility changes while Project.toml still requires v0.4.10, which broke precompilation with "unknown Kind name" errors. The package now loads successfully again. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Fix JuliaSyntax v1 compatibility: API changes and operator detection
Revert JuliaSyntax v1 compatibility changes - incompatible with v0.4.10
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverted all JuliaSyntax v1 compatibility changes because the package is still configured to use JuliaSyntax v0.4.10, not v1.x.
Issue
Previous commits attempted to implement JuliaSyntax v1 compatibility changes:
cartesian_iterator→iterationK"false"→K"Placeholder"for catch block detectionhaschildren()→!is_leaf()These changes broke the package because:
JuliaSyntax = "^0.4.10"K"iteration"orK"Placeholder"kindsChanges Made
All files have been reverted to their original state before the v1 compatibility attempts:
Test Status
Next Steps for v1 Upgrade
To properly upgrade to JuliaSyntax v1, the approach should be:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.