Skip to content

load tables with auto increment key #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
quinnj merged 3 commits into from
Jan 14, 2026
Merged

load tables with auto increment key #230

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0146f7b
load tables with auto increment key
TianChengJiang9911 Jan 6, 2026
6f09f0b
Merge branch 'main' into main
quinnj Jan 14, 2026
5220d19
Fix syntax error: add missing ) in function signature
quinnj Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/load.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,14 @@ const SQLTYPES = Dict{Type, String}(

checkdupnames(names) = length(unique(map(x->lowercase(String(x)), names))) == length(names) || error("duplicate case-insensitive column names detected; sqlite doesn't allow duplicate column names and treats them case insensitive")

function createtable(conn::Connection, nm::AbstractString, sch::Tables.Schema; debug::Bool=false, quoteidentifiers::Bool=true, createtableclause::AbstractString="CREATE TABLE", coltypes=Dict(), columnsuffix=Dict())
function createtable(conn::Connection, nm::AbstractString, sch::Tables.Schema; debug::Bool=false, quoteidentifiers::Bool=true, createtableclause::AbstractString="CREATE TABLE", coltypes=Dict(), columnsuffix=Dict(), auto_increment_primary_key_name::Union{Nothing,AbstractString}=nothing)
names = sch.names
checkdupnames(names)
types = [sqltype(T, coltypes, names[i]) for (i, T) in enumerate(sch.types)]
columns = (string(quoteidentifiers ? quoteid(String(names[i])) : names[i], ' ', types[i], ' ', get(columnsuffix, names[i], "")) for i = 1:length(names))
debug && @info "executing create table statement: `$createtableclause $nm ($(join(columns, ", ")))`"
return DBInterface.execute(conn, "$createtableclause $nm ($(join(columns, ", ")))")
auto_increment_column = (auto_increment_primary_key_name === nothing || isempty(auto_increment_primary_key_name)) ? "" : "$(auto_increment_primary_key_name) INT AUTO_INCREMENT PRIMARY KEY, "
debug && @info "executing create table statement: `$createtableclause $nm ($(auto_increment_column)$(join(columns, ", ")))`"
return DBInterface.execute(conn, "$createtableclause $nm ($(auto_increment_column)$(join(columns, ", ")))")
end

"""
Expand Down Expand Up @@ -97,7 +98,7 @@ function load(itr, conn::Connection, name::AbstractString="mysql_"*Random.randst
# start a transaction for inserting rows
DBInterface.transaction(conn) do
params = chop(repeat("?,", length(sch.names)))
stmt = DBInterface.prepare(conn, "INSERT INTO $name VALUES ($params)")
stmt = DBInterface.prepare(conn, "INSERT INTO $name ($(join(sch.names .|> string .|> quoteid,", "))) VALUES ($params)")
for (i, row) in enumerate(rows)
i > limit && break
debug && @info "inserting row $i; $(Tables.Row(row))"
Expand Down
Loading