Conversation
felixcremer
left a comment
felixcremer
left a comment
There was a problem hiding this comment.
This introduces some strange flickering on zooming also in the local data. Can we somehow restrict this to the cloud data or get rid of the flickering.
|
|
||
| function DiskArrays.cache(p::Pyramid; maxsize=1000) | ||
| maxsize = maxsize ÷ (length(p.levels) + 1) | ||
| Pyramid(DiskArrays.cache(p.base; maxsize), DiskArrays.cache.(p.levels; maxsize), p.metadata) |
There was a problem hiding this comment.
We might want to use the setter functions here instead of the access to the fields of the struct. So it should be parent(p) instead of p.base and DD.metadata(p) instead of p.metadata.
| #First load overview | ||
| overview1 = min(n_agg + 4, nlevels(pyramid)) | ||
| data = levels(pyramid)[overview1][ext] | ||
| odata = Observable{Any}(data) |
There was a problem hiding this comment.
Why is this an Observable{Any} should we restrict this to AbstractDimArray?
|
I also get this strange behaviour at some zoom steps. This is way faster on the screen than on the screencast. It seems as if we can hit some update loops. |
|
I hope that the behaviour that prompted this PR is now also fixed with the new recipes. |
2 participants
I played a bit with the plotting script and adapted it so that it falls back to coarser levels when zooming in and the new data is not loaded yet. This results in smoother zooming although this could still be optimised.