Skip to content

[No Breaking] Refactoring of tests part 1 (organize test files)#213

Merged
kescobo merged 3 commits into
JuliaData:masterfrom
Paalon:test-yaml
Jun 18, 2024
Merged

[No Breaking] Refactoring of tests part 1 (organize test files)#213
kescobo merged 3 commits into
JuliaData:masterfrom
Paalon:test-yaml

Conversation

@Paalon
Copy link
Copy Markdown
Contributor

@Paalon Paalon commented Jun 18, 2024

This PR depends on #212. Refactoring of the tests.

  • Move test YAML input files to test/yaml and Julia output files to test/julia.
  • Rename extensions of test input and output files.
    • *.datayaml/*.yaml
    • *.expectedjulia/*.jl
  • Refactoring of reading test files.

test/invalid-tag.data and test/nested-dicts.data are being used differently, so I leave them as they are for now.

Paalon added 2 commits June 18, 2024 13:55
- Move test YAML input files to `yaml` and Julia output files to `julia`.
- Rename extensions of test input and output files.
  - `*.data` → `yaml/*.yaml`
  - `*.expected` → `julia/*.jl`
- Refactoring of reading test files.
@Paalon
Copy link
Copy Markdown
Contributor Author

Paalon commented Jun 18, 2024

I don't know why Windows tests are failed. Maybe related to #132.

@Paalon
Copy link
Copy Markdown
Contributor Author

Paalon commented Jun 18, 2024

Our implementation seems can not process trailing newlines appropriately in Windows. It should be investigated later.

@Paalon Paalon changed the title Refactoring of tests part 1 (organize test files) [No Breaking] Refactoring of tests part 1 (organize test files) Jun 18, 2024
@Paalon
Copy link
Copy Markdown
Contributor Author

Paalon commented Jun 18, 2024

There is an issue #102 about this.

@kescobo kescobo merged commit 2cbc358 into JuliaData:master Jun 18, 2024
@Paalon Paalon deleted the test-yaml branch June 18, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants