[Not Urgent, Stylistic] Rename length to len.#182
Conversation
kescobo
left a comment
There was a problem hiding this comment.
I'd marginally prefer something more descriptive rather than less - like out_length or str_length or something.
Here, where it's just a lot of find-replace, and it's going to be read a lot more than it's written, trying to be economical at the expense of readability strikes me as a mistake
|
I read
In Julia, I think this variable should mean 1-based position, and the name should be Anyway, this PR is not urgent. It's okay to think about this later. |
length to len.length to len.
I always worry about statements like this - I have on many occasions thought "this will be obvious to future me", and then come back after a couple of months it more and have no idea what's going on. You're probably right that |
For what it's worth, |
Julia
Baseexports the namelengththus rename for disambiguation.