Skip to content

RFC: Clean up operators #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnmyleswhite merged 13 commits into from
Sep 20, 2013
Merged

RFC: Clean up operators #351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b7906c6
Clean up unary operators
simonster Jul 18, 2013
4234ff8
Clean up matrix multiplication
simonster Jul 19, 2013
0c769ec
Only define the necessary similar operator, and make it accept types
simonster Aug 18, 2013
35f7e12
Clean up comparison operators
simonster Aug 18, 2013
f432b01
Clean up arithmetic operators
simonster Aug 19, 2013
4287817
Clean up most remaining operators, and restore operator lists for now
simonster Aug 19, 2013
0e182b1
Remove cov_spearman and colffts from tests
simonster Aug 19, 2013
ddf1124
Move all macros to top
simonster Aug 19, 2013
0849900
Make operator arrays const
simonster Aug 19, 2013
9af8b19
Fix ambiguity warnings
simonster Sep 7, 2013
c7cd915
Fix f(::AbstractArray, ::AbstractDataArray) for binary operators
simonster Sep 20, 2013
d0488e1
Fix pairwise operators when first element fo a DataVector is NA
simonster Sep 20, 2013
3a6a042
Add tests for PooledDataArray and pairwise operators
simonster Sep 20, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/dataarray.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,15 +127,7 @@ end
##
##############################################################################

similar(d::DataArray) = DataArray(similar(d.data), similar(d.na))

function similar{T}(d::DataArray{T}, dims::Int...)
DataArray(Array(T, dims...), trues(dims...))
end

function similar{T}(d::DataArray{T}, dims::Dims)
DataArray(Array(T, dims), trues(dims))
end
similar(d::DataArray, T, dims::Dims) = DataArray(Array(T, dims), trues(dims))
Copy link
Copy Markdown
Contributor

@johnmyleswhite johnmyleswhite Sep 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert this change? I've edited this on my own and now feel like similar should not initialize the na bit mask.

Copy link
Copy Markdown
Contributor Author

@simonster simonster Sep 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can change this not to initialize the na mask, but I still think we only need a single similar function with all the arguments. The one- and two-argument versions of similar in Base will just call this one.

Copy link
Copy Markdown
Contributor

@johnmyleswhite johnmyleswhite Sep 19, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true. I'll make that change on my end.


##############################################################################
##
Expand Down
Loading