simplify the implementation of firstrest using peel

[nsajko]

Iterators.peel is supported on all Julia versions supported by IterTools. In fact, it was already present with Julia v0.7.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.86%. Comparing base (08ce9ae) to head (482313a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
- Coverage   90.88%   90.86%   -0.03%     
==========================================
  Files           1        1              
  Lines         395      394       -1     
==========================================
- Hits          359      358       -1     
  Misses         36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[omus]

Should firstrest be deprecated in favor of Iterators.peel?

[nsajko]

The doc string of firstrest points to Iterators.peel anyway. IMO there is no need to deprecate, but definitely delete firstrest at the time of a breaking release.

[oxinabox]

IMO there is no need to deprecate, but definitely delete firstrest at the time of a breaking release.

Sounds like a good reason to deprecate now

[nsajko]

Another option is to simply define firstrest as:

const firstrest = Iterators.peel

The only difference in behavior would be firstrest(empty_iterator) returning nothing instead of throwing.

[nsajko]

IMO that would be a feature addition, as opposed to a breaking change.