Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
==========================================
+ Coverage 99.75% 99.78% +0.03%
==========================================
Files 1 1
Lines 408 471 +63
==========================================
+ Hits 407 470 +63
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for structured (nested) datatypes, and support for ascii and ucs (also outlined in that link), which some newer Roman data files seem to use. This required changing how the
datatypefield is parsed, so I thought it would be better to have this as a separate PR instead of cramming it into #25.To add this support, the new
AsciiDatatypeandUcs4Datatypetypes were introduced. These are spiritual variants ofDatatype, but since that one is an enum, it seemed like it would be more trouble than it's worth to get them to all subtype a common abstract type.This PR also includes a grip of tests using the reference files from asdf-standard. I just included a copy of the most recent ones (v1.6.0) in the test directory here for simplicity. On a related note, should the asdf spec version printed here be updated to reflect this?
Could be a good first PR to generalize things to dynamically load different versions directly from that repo instead. Another good one might be to start refactoring
src/ASDF.jlnow that it is starting to get a little long