Accept Number orders in calculus operators#154
Merged
jishnub merged 1 commit intoJuliaApproximation:masterfrom Dec 2, 2022
Merged
Accept Number orders in calculus operators#154jishnub merged 1 commit intoJuliaApproximation:masterfrom
Number orders in calculus operators#154jishnub merged 1 commit intoJuliaApproximation:masterfrom
Conversation
Codecov ReportBase: 68.59% // Head: 68.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 68.59% 68.65% +0.06%
==========================================
Files 28 28
Lines 2458 2466 +8
==========================================
+ Hits 1686 1693 +7
- Misses 772 773 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would help with constant propagation in certain cases, using static integers as orders. Currently,
StaticInts are notIntegers, although SciML/Static.jl#92 would mean that this change in unnecessary, in which case this may be reverted.Another example: