move functionality from Javis to JavisViewer#2
move functionality from Javis to JavisViewer#2gpucce wants to merge 12 commits intoJuliaAnimators:mainfrom
Conversation
|
Hi @TheCedarPrince I started working on this, it would be nice if you could merge this PR so we have CI working or give me merge access and I can do it myself. It is not finished yet but just so we can set up some initial stuff it should be good to go, test locally and it works. |
|
I did not know this but since it is not running here CI runs on my fork! So no rush at all!! |
|
Hey @gpucce , you should now have access to all the things! |
|
I can give more of a review later - right now, quite tired! |
|
I was going to ask you if you wanted to move the streaming as well, that I will move back then!! |
|
I think streaming is pretty much basic so better to keep it in base Javis. In the future I am thinking of having such features out of base(in a |
|
Hi @TheCedarPrince this should be the JavisViewer package! If you can review it and let me know if smth is missing i will add it! |
This PR is meant to move all the interactive and liveviewing parts of
JavistoJavisViewerCloses:
#1