Document ObjectDisposedException for CsvReader.GetRecords overloads#2373
Document ObjectDisposedException for CsvReader.GetRecords overloads#2373fuguiKz wants to merge 1 commit intoJoshClose:masterfrom
Conversation
|
Quick ping (no rush): this is doc-only + a small regression test for the deferred-enumeration-after-disposal case (Fixes #2338). No behavior change intended — just documenting the existing ObjectDisposedException contract and locking it in with a test. Happy to tweak wording/placement if you prefer. |
|
Note: the GitHub Actions check suite is currently in an "action required" state (fork workflow approval), so CI hasn't executed. Would a maintainer be able to approve and run the workflows for this PR? This change is docs + a regression test only (no behavioral change intended). Local sanity check (Linux): |
|
FYI: I opened #2376 (tests-only) to address the Linux net8.0 test instability we discussed in #2375. Once #2376 lands, this PR's CI should be less likely to fail for unrelated newline/culture differences. Also, the GitHub Actions check suite here is still |
Fixes #2338
ObjectDisposedExceptionXML docs toCsvReader.GetRecords<T>(T anonymousTypeDefinition)andCsvReader.GetRecords(Type type).Tests:
dotnet test tests/CsvHelper.Tests/CsvHelper.Tests.csproj -c Release -f net9.0 --filter FullyQualifiedName~CsvHelper.Tests.Reading.YieldTests