DisposeAsync async enumerators in CsvWriter#2265
Conversation
|
I went with the other PR since it fixed it in all 3 places. |
|
@JoshClose the other PR is 'better' if you favor consistency over correctness / necessity, i.e. if you want to follow
meaning https://github.com/JoshClose/CsvHelper/pull/2297/files#diff-e2f1fdf3fb99b4d4e65c30f3dc27dff37d93a39a2d8b1f1257f7685f3a97b5b7R638 should not check for neither |
|
I totally read this wrong. Must have been tired. You're definitely correct here. |
|
Hi @JoshClose Sorry to bug you again... I think #2344 would be even better. As an alternative we could use |
fixes #2264
As an alternative we could use
await using var enumerator...but this would increase the difference between the overloads.