improve Combobox Search + Change Hide Instuction button color

[AmraouiH]

No description provided.

[YesWeCandrew]

HI @AmraouiH

Thanks so much for opening this pull request. I'm sorry for how long it's taken me to get around to reviewing it.

I'll review in the next few weeks and if all looks good will release an update with your changes shortly.

Thanks again for contributing - really appreciate it!

Cheers,
Andrew

[YesWeCandrew]

Hey @AmraouiH - thanks so much for suggesting these changes. I can see how they improve the user experience and the change in the instructions button colour is great.

Unfortunately, there are two things that make the app a little harder to use so I don't think this is ready to ship just yet. If you have a chance to action these suggestions then I'd be delighted to merge this in and release an update:

• When an Entity is selected, the Instructions should automatically disappear and it should get the columns in that entity. With this update, it only triggers this if a user selects the entity, not if they press Enter or Tab. This could cause a lot of confusion as someone could map to the columns of Entity A, when they think it is the columns of Entity B. Can you please ensure that both these actions are triggered when an entity is selected, regardless of how it is selected?

• It's much easier to search in the CRM Field and Lookup columns now, however the Enter and Tab keys don't work consistently. When a user presses Enter after they type in those fields, the selected autocompleted option should be chosen and the user should move down to the next row. If no matching option is found it should move to the next row, but without choosing any option. Same for if the user hits tab, but it should move to the next column. Right now, it is inconsistent between Tab and Enter, depending on whether the user has actively clicked on the cell. For me at least, this slows down data mapping.

If you have got the time to implement those changes, I would love to see it (and I have more time to review changes like this now!). No worries at all if you don't though.

Thanks again for your patience.