First swing at ZipFile support. (Issue #16)#17
Draft
JosephCatrambone wants to merge 3 commits intomainfrom
Draft
First swing at ZipFile support. (Issue #16)#17JosephCatrambone wants to merge 3 commits intomainfrom
JosephCatrambone wants to merge 3 commits intomainfrom
Conversation
…ingest. Need a better method in indexed image for reading from in-mem images.
Owner
Author
|
Current change breaks things. |
Owner
Author
|
Problem was I was only doing buffer.read() instead of buffer.read_to_end(). The one thing that should probably get cleaned up before this is merged is the view screen, which expects that the file is readable from disk. If it comes in as a zipfile and we can't just open it, we might hit problems. Perhaps the indexedimage needs an extra field for 'image is stored as zip'? |
…rom a zip we might know. Not very happy with this solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are a little messy. I think the IndexedImage file needs a better way to read from an in-memory image. The handling of zipfiles is also not great, and I think when we start monitoring for on-disk changes it's going to get worse. Perhaps the crawler's ingesting methods could be split off into a separate file.
WIP for #16