Skip to content

Fixes #7#8

Open
rakibansary wants to merge 1 commit intoJoris-van-der-Wel:masterfrom
rakibansary:master
Open

Fixes #7#8
rakibansary wants to merge 1 commit intoJoris-van-der-Wel:masterfrom
rakibansary:master

Conversation

@rakibansary
Copy link
Copy Markdown

No description provided.

@Joris-van-der-Wel
Copy link
Copy Markdown
Owner

Was this a breaking change in pg-promise? @vitaly-t

As far as I know it all used to work properly before.
If this is the case, would it be possible to support both the old and new pg-promise? If not, we should add a peerDependency to avoid surprises when existing users upgrade node-pg-large-object.

@vitaly-t
Copy link
Copy Markdown

Was this a breaking change in pg-promise?

No, there wasn't any such change.

@Joris-van-der-Wel
Copy link
Copy Markdown
Owner

@rakibansary thanks for the issue and PR.

However, could you give some more details on how to reproduce the original problem? When I try to run my test cases, with the latest version of pg and pg-promise, everything works as expected.

@rakibansary
Copy link
Copy Markdown
Author

Hi @Joris-van-der-Wel thanks for checking this out.

I'll see if I can take a look at reproducing the issue with concrete steps later today or tomorrow afternoon. But if I remember correctly, initially I'd simply followed the steps outlined in the README file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants