Optional support for Quick + Nimble testing via Cocoapods#58
Open
KieranHarper wants to merge 19 commits intoJohnSundell:masterfrom
Open
Optional support for Quick + Nimble testing via Cocoapods#58KieranHarper wants to merge 19 commits intoJohnSundell:masterfrom
KieranHarper wants to merge 19 commits intoJohnSundell:masterfrom
Conversation
The test lane does a regular build for the watchOS target (because there aren't any tests), then does a build+test (aka scan) step for the other 3 targets. Unwanted targets can be removed and extra iOS devices can be added easily. Useful for CI because all you have to do is run `fastlane test`.
…the workspace if project wants to use cocoa pods.
…en copying. The idea is that items in the optional folder can be selectively copied depending on the answers to questions / what the project needs.
Only gets copied from the "optional" folder if the user says yes to it.
Architectures need to match between project targets and pod targets, and the one that makes sense as a default is for debug to build the active one only. Without this the iOS target is the odd one out that wants to build all architectures, and pods doesn't agree with that.
…en copying. The idea is that items in the optional folder can be selectively copied depending on the answers to questions / what the project needs.
Only gets copied from the "optional" folder if the user says yes to it.
…late into quick+nimble
… aware of it as well. The downside of this is you can't currently have testing without including Q+N as dependencies for building as well. Not sure that SPM supports that at the moment, the conversation suggests not yet.
Closed
remirobert
approved these changes
Sep 3, 2017
Contributor
|
FYI, Swift 4's SPM now supports test dependencies 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couple of things here:
That last point creates a slight problem if you want to test via
swift testyou'll end up having those dependencies included when youswift buildas well, which isn't ideal. It's a known issue for SPM that's being worked on (I'm not completely across the status tho). I've included it here by default because it means this can hit all platforms, but people can also delete it if they're happy to just test through Xcode. If you merge this PR I'll create an issue to track that.