feat: add "Top Rivalries" gaming-style marquee ticker to Compare page#3583
Open
code-with-abhi-i5 wants to merge 6 commits into
Open
feat: add "Top Rivalries" gaming-style marquee ticker to Compare page#3583code-with-abhi-i5 wants to merge 6 commits into
code-with-abhi-i5 wants to merge 6 commits into
Conversation
…card to preview both features together
Contributor
|
@code-with-abhi-i5 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a highly dynamic "Top Rivalries" marquee ticker at the top of the Developer Showdown page. It gives the page an immediate "Gaming Leaderboard" / "Live Broadcast" feel and solves the "blank slate" problem by giving users instantly clickable, high-profile developer match-ups to explore (e.g., Linus Torvalds vs Dan Abramov).
Fixes #3582
Pillar
Visual Preview
framer-motion) above the search bar.bg-gradient-to-r).What's Changed
[NEW]
components/TopRivalriesTicker.tsxframer-motion(x: ['0%', '-50%']).[...MOCK_RIVALRIES, ...MOCK_RIVALRIES]) to achieve a mathematically perfect, seamless infinite loop.handleRivalryClickwhich usesnext/navigationrouter to push the?user1=...&user2=...parameters, triggering the existing Auto-CompareuseEffectinCompareClient.[MODIFY]
app/compare/CompareClient.tsx<>) to allow full-width bleeding of the ticker outside themax-w-5xlcontainer.pt-20 lg:pt-24) to position the ticker perfectly below the fixed Navbar.Checklist before requesting a review:
CONTRIBUTING.mdfile.localhost:3000/compare).npm run formatandnpm run lintlocally and resolved all errors (CI will fail otherwise).feat: add Top Rivalries ticker...).