test(CompareClient-timezone-boundaries): verify Timezone Normalization & Calendar Data Boundary Alignment#3563
Open
AryanRajuBankar3000 wants to merge 1 commit into
Conversation
…n & Calendar Data Boundary Alignment
Contributor
|
@AryanRajuBankar3000 is attempting to deploy a commit to the jhasourav07's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
PR is officially ready for review! All 5 timezone and calendar boundary tests are passing perfectly. Used Vitest's fake timers to safely simulate the leap year and daylight savings time transitions without causing any flakiness based on local machine clocks. Let me know if everything looks good to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2790
Hey @souravjhahind, the isolated unit and integration testing for the
CompareClienttimezone normalization and calendar data boundaries is complete! All 5 test cases are successfully passing.Implementation details:
next/navigationandrechartsto ensure the component mounts safely in the JSDOM environment without native browser context or SVG rendering crashes.vi.useFakeTimers()to safely hijack the system clock and manipulate dates without impacting other test suites.vi.setSystemTime()to standardize date checks and eliminate test flakiness across different local environments.Pillar
Visual Preview
N/A - This PR strictly adds testing infrastructure (
CompareClient.timezone-boundaries.test.tsx), so there are no visual UI changes.Checklist before requesting a review:
CONTRIBUTING.mdfile.npm run formatandnpm run lintlocally and resolved all errors.README.mdif I added a new theme or URL parameter.