JBAI-18822 Refactor ai.koog:agents-ext module to extract files-rela…#1278
Merged
Elizaveta239 merged 2 commits intodevelopfrom Jan 13, 2026
Merged
JBAI-18822 Refactor ai.koog:agents-ext module to extract files-rela…#1278Elizaveta239 merged 2 commits intodevelopfrom
ai.koog:agents-ext module to extract files-rela…#1278Elizaveta239 merged 2 commits intodevelopfrom
Conversation
Qodana for JVM1177 new problems were found
@@ Code coverage @@
+ 72% total lines covered
17738 lines analyzed, 12845 lines covered
# Calculated according to the filters of your coverage tool☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
kpavlov
reviewed
Jan 3, 2026
…ted abstractions from agents
Co-authored-by: Konstantin Pavlov <1517853+kpavlov@users.noreply.github.com>
cf30df8 to
7ea5142
Compare
Contributor
Author
|
Updated to the fresh |
denis-domanskii
approved these changes
Jan 12, 2026
vova-jb
pushed a commit
that referenced
this pull request
Jan 27, 2026
…ctions from agents (#1278) <!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> Currently, we (EmbArk) have a dependency on Code Engine's module `ai.jetbrains.code.files:code-files-model`, which is rather small module for working with files and filesystem. But the problem is that it has dependencies on one class from koog: `ai.koog.agents.ext.tool.file.filter.GlobPattern` which is located in `ai.koog:agents-ext` and adds dependencies on many various koog-related modules (and even on `ktor-server`). So I moved `GlobPattern.kt`, `FileSize.kt`, `FileSystemEntry.kt` and `FileSystemEntryBuilders.kt` from `ai.koog:agents-ext` to `rag:rag-base` module. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [x] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated --------- Co-authored-by: Konstantin Pavlov <1517853+kpavlov@users.noreply.github.com>
sdubov
pushed a commit
that referenced
this pull request
Feb 23, 2026
…ctions from agents (#1278) <!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> Currently, we (EmbArk) have a dependency on Code Engine's module `ai.jetbrains.code.files:code-files-model`, which is rather small module for working with files and filesystem. But the problem is that it has dependencies on one class from koog: `ai.koog.agents.ext.tool.file.filter.GlobPattern` which is located in `ai.koog:agents-ext` and adds dependencies on many various koog-related modules (and even on `ktor-server`). So I moved `GlobPattern.kt`, `FileSize.kt`, `FileSystemEntry.kt` and `FileSystemEntryBuilders.kt` from `ai.koog:agents-ext` to `rag:rag-base` module. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [x] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated --------- Co-authored-by: Konstantin Pavlov <1517853+kpavlov@users.noreply.github.com>
sdubov
pushed a commit
that referenced
this pull request
Feb 23, 2026
…ctions from agents (#1278) <!-- Thank you for opening a pull request! Please add a brief description of the proposed change here. Also, please tick the appropriate points in the checklist below. --> ## Motivation and Context <!-- Why is this change needed? What problem does it solve? --> Currently, we (EmbArk) have a dependency on Code Engine's module `ai.jetbrains.code.files:code-files-model`, which is rather small module for working with files and filesystem. But the problem is that it has dependencies on one class from koog: `ai.koog.agents.ext.tool.file.filter.GlobPattern` which is located in `ai.koog:agents-ext` and adds dependencies on many various koog-related modules (and even on `ktor-server`). So I moved `GlobPattern.kt`, `FileSize.kt`, `FileSystemEntry.kt` and `FileSystemEntryBuilders.kt` from `ai.koog:agents-ext` to `rag:rag-base` module. ## Breaking Changes <!-- Will users need to update their code or configurations? --> --- #### Type of the changes - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] Documentation update - [ ] Tests improvement - [x] Refactoring #### Checklist - [x] The pull request has a description of the proposed change - [x] I read the [Contributing Guidelines](https://github.com/JetBrains/koog/blob/main/CONTRIBUTING.md) before opening the pull request - [x] The pull request uses **`develop`** as the base branch - [x] Tests for the changes have been added - [x] All new and existing tests passed ##### Additional steps for pull requests adding a new feature - [ ] An issue describing the proposed change exists - [ ] The pull request includes a link to the issue - [ ] The change was discussed and approved in the issue - [ ] Docs have been added / updated --------- Co-authored-by: Konstantin Pavlov <1517853+kpavlov@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ted abstractions from agents
Motivation and Context
Currently, we (EmbArk) have a dependency on Code Engine's module
ai.jetbrains.code.files:code-files-model, which is rather small module for working with files and filesystem. But the problem is that it has dependencies on one class from koog:ai.koog.agents.ext.tool.file.filter.GlobPatternwhich is located inai.koog:agents-extand adds dependencies on many various koog-related modules (and even onktor-server).So I moved
GlobPattern.kt,FileSize.kt,FileSystemEntry.ktandFileSystemEntryBuilders.ktfromai.koog:agents-exttorag:rag-basemodule.Breaking Changes
Type of the changes
Checklist
developas the base branchAdditional steps for pull requests adding a new feature