Skip to content

Fix missing tool support in Ollama streaming client#1257

Closed
MHchangjun wants to merge 3 commits intoJetBrains:developfrom
MHchangjun:streaming_tool_ollama
Closed

Fix missing tool support in Ollama streaming client#1257
MHchangjun wants to merge 3 commits intoJetBrains:developfrom
MHchangjun:streaming_tool_ollama

Conversation

@MHchangjun
Copy link
Copy Markdown

@MHchangjun MHchangjun commented Dec 10, 2025

Motivation and Context

The streaming Ollama client was not sending the tools parameter, so tool calls could never be triggered in streaming mode.
This PR adds the missing tools field for consistency with the non-streaming path and to support models that can use tools.

Breaking Changes

None


Type of the changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tests improvement
  • Refactoring

Checklist

  • The pull request has a description of the proposed change
  • I read the Contributing Guidelines before opening the pull request
  • The pull request uses develop as the base branch
  • Tests for the changes have been added
  • All new and existing tests passed
Additional steps for pull requests adding a new feature
  • An issue describing the proposed change exists
  • The pull request includes a link to the issue
  • The change was discussed and approved in the issue
  • Docs have been added / updated

Copy link
Copy Markdown
Contributor

@kpavlov kpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @MHchangjun! We also a test.

@kpavlov kpavlov added the enhancement New feature or request label Jan 5, 2026
@aozherelyeva
Copy link
Copy Markdown
Contributor

I think we can close this one as outdated. Please rebase to the develop and open a new PR in case the change is still actual 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants