NEM-366 Ensure deterministic ordering on file export#115
Open
Mateus-Cordeiro wants to merge 3 commits intomainfrom
Open
NEM-366 Ensure deterministic ordering on file export#115Mateus-Cordeiro wants to merge 3 commits intomainfrom
Mateus-Cordeiro wants to merge 3 commits intomainfrom
Conversation
JulienArzul
approved these changes
Feb 5, 2026
Collaborator
Very good point, it would probably still be a good idea to use an ORDER BY on the samples (probably on the primary key?) so that at least two subsequent calls to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes YAML exports deterministic by preserving model-defined field order when serializing dataclasses and Pydantic models.
PyYAML's default behaviour can produce noisy diffs due to unstable key ordering.
Changes
yaml.py's YAML representer to handle dataclasses and Pydantic modelsLimitations
Database samples can't be guaranteed to be deterministic. At the moment, a sampling query looks like this:
At the point in the code in which we obtain samples, we know the columns of the table, so an
ORDER BYclause could be created. This, however, would not guarantee that the same rows would be returned.