Merged
Conversation
…onnections and streamline setup/cleanup scripts
…ign setup/cleanup scripts
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Snowflake Streamlit demo and CLI UI wiring to support Snowflake OAuth/session-token based authentication, and introduces a new “separate_executor” option for the Streamlit UI’s agent executor selection.
Changes:
- Add a new
separate_executorexecutor option and instantiateSeparateExecutorin the Streamlit UI agent initialization path. - Update Snowflake demo app/config to use a Snowflake session token (
/snowflake/session/token) and shift datasource auth toward token-based configuration. - Pin
databao-agent/databao-context-engine[snowflake]to specific dev builds that presumably contain the needed Snowflake OAuth changes.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/databao_cli/shared/executor_utils.py | Adds separate_executor to the executor selector options used by the UI. |
| src/databao_cli/features/ui/app.py | Creates SeparateExecutor when executor_type is separate_executor. |
| pyproject.toml | Pins core dependencies to specific dev versions. |
| examples/demo-snowflake-project/src/databao_snowflake_demo/app.py | Loads Snowflake session token into SNOWFLAKE_DS_TOKEN when running in Snowflake. |
| examples/demo-snowflake-project/setup.sql | Removes Snowflake datasource account/user/password secrets from the demo provisioning script. |
| examples/demo-snowflake-project/pyproject.toml | Pins demo dependencies to match the new Snowflake/OAuth-capable stack. |
| examples/demo-snowflake-project/databao/domains/root/src/snowflake.yaml | Switches datasource config to token auth and new env var names for account/host. |
SimonKaran13
approved these changes
Apr 7, 2026
Member
SimonKaran13
left a comment
SimonKaran13
left a comment
There was a problem hiding this comment.
Code LGTM
I'm still waiting on Snowflake credentials to manually test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.