forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 118
Native iOS text input #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mazunin-v-jb
wants to merge
12
commits into
jb-main
Choose a base branch
from
v.mazunin/native-ios-text-input
base: jb-main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Native iOS text input #2602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd397ec to
c0251cd
Compare
7b04420 to
78ec253
Compare
a2d64d8 to
e1a2e1f
Compare
c4fb706 to
d3380e7
Compare
- deleted debug prints - fixed crashes during text input in NITI which had been caused by the late update of TextLayoutResult, reverted hack with checking MultiParagraph text length - Fixed crash with text autocorrection - Fix cursor width, fix context menu appearance by cursor tap - Fix tint color - Fix text field cursor activation - fixed generated comments in IOSSkikoInput.uikit.kt - clean up IntermediateTextInputUIView.uikit.kt - removed unnecessary imports from IntermediateTextInputUIView.uikit.kt, removed unnecessary method from IOSSkikoInput.uikit.kt - reverted observeSelectionChanges in commonMain part of BTF2, which seem unnecessary - reverted accidental commit of debug flags - remove unnecessary macos actuals, added one universal macos actual - fixed CMPUtils header - reverting unnecessary changes - xcodeproj fixes - Fixed lack of items in the context menu with NITI - Forwarded cursor / selection colors in TF1 / TF2 - Disabled Compose cursor in NITI mode in both TFs - Created expect / actual for the Compose text selection highlight in TF1, hidden it under NITI flag in uikit sourceset - Renamed UIKitTextContextMenuHandler.kt into more appropriate UIKitNativeTextInputContext - Created expect / actual for altering drawing selection rect on different platforms - fixed incorrect positioning of context menu - disabled back newContextMenu flag, rewrote showEditMenu logic in UIKitTextInputService.uikit.kt with using NITI toggle, created a signle entry point for context menu, removed some comments - context menu without NITI fixes + added existing obj-c files to the project which were forgotten to add during the merge - merge fixes after commit with refactoring InputViews.uikit.kt - Reverted pointerInput handling in TF1,2, reverted view hierarchy, hidden almost everything related to the NITI under the flag, added some TODOs with bad fixes - Added feature flag for NITI to platform ime options - added NITI tests screens to the example app - Forwarded custom actions to the IntermediateTextInputUIView.uikit.kt - Enabled native context menu, added public API for updating context menu state (foundation -> ui), extracted all UITextInput methods from objc file to separate class, temporarily disabled current context menu - Extracted UITextInput methods from CMPEditMenuView to CMPTextInputView, fixed NewContextMenuApi menu - (wip) commented CMPEditMenu methods calls after rebase with new context menu api on ios - (wip) turned on native selection rects (LTR only!) + fixed appearing of the text editing menu by tapping on the selection rects + more appropriate naming + fixed imports - (wip) disabled custom iOS tap handlers in TF1,2 - (wip) fixed native text views positioning in TF1 - (wip) disabled compose selection handles - (wip) fixed scroll positioning in BTF2 - (wip) fixed touch forwarding - (wip) fixed positioning of ScrollView and TextView issue - (wip) removed unnecessary comments - (wip) fixed sizing of TextScrollView and TextView - (wip) transfered changes from previous niti branch - (wip) rebase fixes
…election change")
b38a420 to
00d1528
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces an opt-in Native iOS Text Input (NITI) mode for Compose
TextFieldon iOS, enabled viaPlatformImeOptions.useNativeInputHandling(enabled)in the iOS source setWith the flag set to
true, Compose text fields use UIKit-native text editing and interaction behavior, details in the release notesKey changes
PlatformImeOptionsflag:useNativeInputHandlingUIKitTextInputService.ios.ktIntermediateTextInputUIView.ios.ktContextMenu.ios.ktsetNeedsRedrawwith an explicitdraw()call inupdateViewclosure inUIKitTextInputServiceto eliminate a race condition between UIKitUITextInputqueries andTextLayoutResultupdates. This could leave iOS with stale text field state, which in NITI mode resulted in incorrect caret positioning and a crash. The fix applies to both NITI and non-NITI scenarios (non-NITI impact was largely not user-visible)LaunchedEffect(throughstartNotifyingAboutContextMenuItems).isNewContextMenu = true): updates viaNitiContextMenuUpdaterElement.CMPEditMenuCustomActionCMPTextInputStringTokenizerCMPTextInputViewto ensure correct UIKit text input behavior in NITI mode.CMPEditMenuViewnow inherits fromCMPTextInputViewto unify UIKit text input handling for edit menu interactionsCommon code changes
To allow the platform (UIKit) to draw cursor/selection when NITI is enabled, common text field rendering was refactored:
CoreTextField.ktplatformShouldDrawTextControls(expect) to let the platform decide whether it draws cursor/selectionTextFieldDelegate.ktdrawHighlightnow accepts adrawSelectionHighlightflag and skips selection highlighting when the platform handles drawingTextFieldCoreModifier.ktdrawPlatformSelection/drawPlatformCursorinstead of inline drawingAdded API
UIKitNativeTextInputContextuiandfoundationmodulesLocalNativeTextInputContextUIKitNativeTextInputContextPlatformTextInputMethodRequest.textUnclippingOffsetInRootIntermediateTextInputUIViewsize/position when extra margins are applied and/or when the text field needs to be scrollableTesting
Manual
Create an expect/actual for KeyboardOptions
Common source set:
iOS source set:
Then use it on any
TextFieldin common code (BasicTextField(TextFieldState)as an example):Open Components -> NITI Tests (WIP: coming later)
Automated
Release Notes
Features - iOS
BasicTextField(bothTextFieldValueandTextFieldState) enabled viaPlatformImeOptions.useNativeInputHandling(enabled)in iOS source settrue,BasicTextFielduses native UIKit editing and interaction, including: