Implement fadc250 parsing example using JANA2#1
Merged
RaiqaRasool merged 2 commits intomainfrom Sep 12, 2025
Merged
Conversation
nathanwbrei
requested changes
Sep 11, 2025
Collaborator
nathanwbrei
left a comment
nathanwbrei
left a comment
There was a problem hiding this comment.
Don't be fooled by all the critiques I left. The code here is close to perfect and is an excellent example for how people ought to be using JANA.
|
|
||
| struct FADC250 : public JObject { | ||
| JOBJECT_PUBLIC(FADC250) | ||
|
|
Collaborator
There was a problem hiding this comment.
Is this really what gets read out? Looks suspiciously simple
Collaborator
Author
There was a problem hiding this comment.
It probably is not completely correct, but this is the best I could make sense of for now. I’ll likely update it after discussing with David.
Collaborator
There was a problem hiding this comment.
Sounds good. This is really a question for Hanjie at the end of the day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.