Closed
Conversation
CalibrationConstantsLoader had three critical issues: 1. CSTLOADED gate prevented reload across runs: once constants loaded for the first run, the flag blocked all subsequent loads. If the data stream (hipo files) switched to a different run number, all engines kept using the first run's calibration. The first event in a files is often run number 0. 2. ATOFEngine never updated its Run field after calling Load(), so the run-change check (Run != newRun) was always true. This would have caused a reload on every event, but bug #1 masked it. 3. All calibration data lived in static HashMap fields shared across engine instances. Not thread-safe. The fix removes CalibrationConstantsLoader entirely. Each engine now: - Holds its own calibration maps as instance fields - Rebuilds them from ConstantsManager (which already caches per run with proper synchronization) only when the run number changes - Passes the maps explicitly to consumer code (HitReader, ATOFHit, BarHit) instead of relying on static access - Only requires its own detector's CCDB tables in init()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.