mode works with all iterables#9
Open
pacman82 wants to merge 1 commit intoJeffBelgum:masterfrom
pacman82:master
Open
mode works with all iterables#9pacman82 wants to merge 1 commit intoJeffBelgum:masterfrom pacman82:master
pacman82 wants to merge 1 commit intoJeffBelgum:masterfrom
pacman82:master
Conversation
... but breaks interface for ranges not moving ownership of elements during iteration
Owner
|
Hi @pacman82, Thanks for your PR! I'm quite busy for the rest of this week, but I'll check it out over the weekend. Cheers, |
Author
|
thx, looking forward to your feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed mode interface from &[] slices to IntoIterator. Sadly, I think it would take unstable compiler features to make mode return primitives by value instead of references for ranges not moving ownership of elements during iteration. Or am I mistaken?