-
Notifications
You must be signed in to change notification settings - Fork 23
Add intel macOS build #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
WalkthroughAdded Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I think this is ready, both x86_64 and arm64 mach-o binaries are being generated. Based on the automated testing we do as part of the build, I'm fairly comfortable with saying this is probably working and can be merged. Any concerns @Jayy001 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/main.yml (1)
165-171: Bug:jobs.devicereferences${{ matrix.os }}butdevicehas no matrix.
This will break artifact naming (and may error during expression evaluation). Use a fixed name (e.g.,remarkable-compilation-report) or${{ github.job }}.- name: Upload Compilation Report uses: actions/upload-artifact@v4 if: runner.debug == '1' with: - name: ${{ matrix.os }}-compilation-report + name: remarkable-compilation-report path: compilation-report.xml if-no-files-found: warn
🧹 Nitpick comments (1)
.github/workflows/main.yml (1)
193-208: Disk cleanup step is reasonable; consider addingsudo apt-get clean -yfor a bit more space (optional).
Current step is fine as-is.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/main.yml(7 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: Build for ubuntu-latest
- GitHub Check: Build for windows-latest
- GitHub Check: Build for macos-15-intel
- GitHub Check: Build for macos-latest
- GitHub Check: Build for remarkable
🔇 Additional comments (7)
.github/workflows/main.yml (7)
7-15: Workflow triggers now include.github/workflows/main.ymlchanges (good), but verify path globs are intended for your repo layout.
If this repo relies on files outside these globs (e.g., non-.pysources,pyproject.toml, etc.), CI may not run when it should.Also applies to: 20-28
56-58: Brew install condition looks correct, contingent onmacos-15-intelactually existing.
No further concerns here.
72-75:setup-pythonquoting changes are fine; pinning Python 3.12 is clear and stable.
No issues.
88-94: Artifact uploadifis now robust (uploads on success/failure when debug enabled).
Good for diagnostics without failing the job.
184-187: Quotingfw_versionstrings is a good fix (prevents YAML numeric coercion).
No issues.
214-215: Verify the newcodexctl downloadinvocation is correct (--out /tmp toltec).
This looks like an argument-order change; iftoltecis meant to be a positional sub-arg, ensure the CLI parses it as intended (and that/tmpexists/has space on the runner + in the reMarkable action environment).
218-218: Release now correctly waits ontest_device(stronger gate), but ensure you want releases blocked iftest_deviceis later expanded/flaky.
Considercontinue-on-errorfortest_deviceonly if you want “soft” gating.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.