Fix device type parsing

[Eeems]

Fix #146

Summary by CodeRabbit

• Bug Fixes
  • Improved device type recognition by normalizing accepted model names to lowercase and consolidating duplicate or stray name variants.
  • Removed inconsistent capitalization variants to ensure consistent handling of supported device models.
  • No changes to public interfaces or visible behavior beyond input normalization.

[coderabbitai]

Walkthrough

Normalized the set of string literals used by HardwareType.parse to lowercase device-type variants (e.g., "remarkable 1.0", "remarkable 2.0"), removed several capitalized/duplicate variants, and added a trailing blank line in the file.

Changes

Cohort / File(s)	Summary
Hardware type parsing normalization codexctl/device.py	Adjusted HardwareType.parse accepted device-type literals to use lowercase variants ("remarkable 1.0", "remarkable 2.0", "remarkable ferrari", etc.), removed several capitalized or duplicate variants, and added a trailing blank line. No public signatures changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review HardwareType.parse string match set for completeness against actual device-reported strings (e.g., mixed-case "reMarkable 2.0").
• Confirm removal of duplicate/variant entries (e.g., variant for "ferrari") is intentional and won't break detection for any deployed devices.
• Minimal formatting change (trailing blank line) requires no functional review.

Possibly related PRs

• Consolidate device type logic & add --hardware option to codexctl list #141 — Modifies the same HardwareType.parse logic in codexctl/device.py; likely directly related to the parsing variants adjusted here.

Pre-merge checks and finishing touches

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Out of Scope Changes Check	⚠️ Warning	While the primary device type parsing adjustments align with issue #146, the raw summary indicates an additional change: adding an extra trailing blank line at the end of the output_put_progress function. This formatting change appears unrelated to the device type parsing objective defined in issue #146, as it does not contribute to fixing the ValueError or improving hardware type recognition.	Remove the trailing blank line addition to the output_put_progress function, as it is outside the scope of fixing device type parsing. Keep the focus of this PR narrowly scoped to the HardwareType.parse string normalization changes that directly address issue #146.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "Fix device type parsing" directly and clearly summarizes the main change in the pull request. The core modification involves hardening the HardwareType.parse method to properly handle device type string comparisons by normalizing capitalization variants, which is exactly what the title conveys. The title is concise, specific, and would clearly communicate the primary change to a developer reviewing the commit history.
Linked Issues Check	✅ Passed	The code changes directly address the objective stated in issue #146. The linked issue reports a ValueError when parsing "reMarkable 2.0" as a device type during the restore command. The PR fix modifies HardwareType.parse to normalize device type string literals to lowercase equivalents, replacing "reMarkable 2.0" with "remarkable 2.0" and consolidating capitalization variants. This directly resolves the parsing failure and allows the restore command to recognize the hardware string from the affected device.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch Eeems-patch-2

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 711f57c and fe62e45.

📒 Files selected for processing (1)

• codexctl/device.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• codexctl/device.py

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Build for macos-latest
• GitHub Check: Build for ubuntu-latest
• GitHub Check: Build for remarkable
• GitHub Check: Build for windows-latest

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 74d13bb and 711f57c.

📒 Files selected for processing (1)

• codexctl/device.py (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)

• GitHub Check: Build for macos-latest
• GitHub Check: Build for ubuntu-latest
• GitHub Check: Build for windows-latest
• GitHub Check: Build for remarkable

🔇 Additional comments (2)

codexctl/device.py (2)

28-29: Correctly fixes issue #146.

Changing "reMarkable 2.0" to "remarkable 2.0" properly aligns with the .lower() transformation on the input, resolving the ValueError reported in issue #146 for devices that report themselves as "reMarkable 2.0".

---

30-31: LGTM!

Consistent with the RM2 fix, this correctly normalizes the comparison strings to lowercase, preventing similar parsing failures for RM1 devices.