Skip to content

ops(CI): add benchmark CI job#86

Merged
JayanAXHF merged 1 commit intomainfrom
ops/benchmark-action
Mar 8, 2026
Merged

ops(CI): add benchmark CI job#86
JayanAXHF merged 1 commit intomainfrom
ops/benchmark-action

Conversation

@JayanAXHF
Copy link
Owner

No description provided.

Copy link
Owner Author

JayanAXHF commented Mar 8, 2026

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 8, 2026

Greptile Summary

This PR splits the existing rust.yml CI workflow into two separate workflows: a new build.yml handling build and Clippy linting, and a trimmed rust.yml focused on tests and benchmarks.

Key issues found:

  • Both build.yml and rust.yml share the workflow name name: Rust, which will cause both to appear identically in the GitHub Actions UI and make it hard to distinguish them.
  • The job inside rust.yml is still named build even though it no longer runs any build steps — it only runs tests and benchmarks.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    PR[Pull Request or Push to main]

    PR --> W1[build.yml]
    PR --> W2[rust.yml]

    subgraph BuildWorkflow["build.yml - job: build"]
        B1[checkout]
        B2[cargo build --verbose]
        B3[cargo clippy]
        B1 --> B2 --> B3
    end

    subgraph TestWorkflow["rust.yml - job: build (misleading name)"]
        T1[checkout]
        T2[cargo test --verbose]
        T3[cargo bench -F benches]
        T1 --> T2 --> T3
    end

    W1 --> BuildWorkflow
    W2 --> TestWorkflow
Loading

Comments Outside Diff (1)

  1. .github/workflows/rust.yml, line 13 (link)

    The job is still named build, but the build and clippy steps have been moved to build.yml. This job now only runs tests and benchmarks. Renaming it avoids confusion when reading workflow run logs or status checks.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Last reviewed commit: 48d3273

@JayanAXHF JayanAXHF force-pushed the 03-08-test_add-tests branch from d4351a9 to 1bf264a Compare March 8, 2026 05:57
@JayanAXHF JayanAXHF force-pushed the ops/benchmark-action branch from 48d3273 to 65a5445 Compare March 8, 2026 05:58
Copy link
Owner Author

JayanAXHF commented Mar 8, 2026

Merge activity

  • Mar 8, 6:04 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Mar 8, 6:07 AM UTC: Graphite rebased this pull request as part of a merge.
  • Mar 8, 6:08 AM UTC: @JayanAXHF merged this pull request with Graphite.

@JayanAXHF JayanAXHF changed the base branch from 03-08-test_add-tests to graphite-base/86 March 8, 2026 06:05
@JayanAXHF JayanAXHF changed the base branch from graphite-base/86 to main March 8, 2026 06:06
@JayanAXHF JayanAXHF force-pushed the ops/benchmark-action branch from 65a5445 to 38025b4 Compare March 8, 2026 06:07
@JayanAXHF JayanAXHF merged commit 5cd5577 into main Mar 8, 2026
4 checks passed
@JayanAXHF JayanAXHF deleted the ops/benchmark-action branch March 8, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant