Add shimmer transmutations to the recipe browser#142
Open
Kyryh wants to merge 6 commits intoJavidPack:1.4from
Open
Add shimmer transmutations to the recipe browser#142Kyryh wants to merge 6 commits intoJavidPack:1.4from
Kyryh wants to merge 6 commits intoJavidPack:1.4from
Conversation
It registers fake recipes with a condition that you can never actually fulfill, that way it doesn't change the gameplay in any way
Now it doesn't add the "Recipe added by mod" tooltip if the mod in question is Recipe Browser Useful only now with fake shimmer recipes
Now it adds "None" to the required objects only if the recipe has no required tiles and no conditions
whoopsies
Owner
|
Thanks, I'll try to take a look soon when I have some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And other minor things about recipe info displaying, like:
There were multiple approaches that could've be done, so I went with the easiest one (I hope that's ok): simply adding the shimmer transmutations as fake recipes with a condition that can never be fulfilled, that way the recipe browser is able to seamlessly detect it and add it, and it shouldn't change anything gameplay-wise since you can never actually craft the items because of the condition