Fall back to page URL if no script tags present#1
Open
themightychris wants to merge 1 commit intomasterfrom
Open
Fall back to page URL if no script tags present#1themightychris wants to merge 1 commit intomasterfrom
themightychris wants to merge 1 commit intomasterfrom
Conversation
The previous code assumed that at least one script tag exists on a page and crashes if this is not true. Further, it does not make use of the `len` variable that is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code assumed that at least one script tag exists on a page and crashes if this is not true. Further, it does not make use of the
lenvariable that is available.When used to build browser extensions, it is possible for the page an application is loaded onto to contain no script tags