Added Inheritances and Exports | Fixed Embed not Sending when you change blips while on-duty.#6
Open
NickReagan wants to merge 6 commits intoJaredScar:masterfrom
Open
Added Inheritances and Exports | Fixed Embed not Sending when you change blips while on-duty.#6NickReagan wants to merge 6 commits intoJaredScar:masterfrom
NickReagan wants to merge 6 commits intoJaredScar:masterfrom
Conversation
Author
|
There is a lot of nested for loops... I am trying to think of ways to optimize it but it works lol. At least the code doesn't run 24/7 and just on player join or resource restart. Also on resource restart it goes through the online players and registers them and waits half a second before doing the next player. Hopefully that is enough for it not to get rate limited. |
JaredScar
reviewed
Feb 7, 2023
JaredScar
reviewed
Feb 7, 2023
Author
|
Everything seems to be working fine. |
Author
|
Done extensive testing on my live server. Good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been need Inheritances for awhile so I spent a few hours and did it :P
Also made a PR for your docs @JaredScar