Conversation
Signed-off-by: Sora Morimoto <sora@morimoto.io>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the vendored Corti test helper and switches to the official corti package, updating mocks and imports accordingly.
- Import
SpeechRecognitionfromcortirather than a local vendor file - Replace
../tests/vendor/corti.jsandRecognitionManagerimports with the new package - Update
vi.mockcalls and test setup to use thecortipackage and hoisted mock functions
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/isAndroid.test.js | Removed describe wrapper and streamlined imports for top-level Vitest hooks |
| src/android.test.js | Dropped vendor import, added corti package import, updated mocks, moved lifecycle calls to root |
| src/SpeechRecognition.test.js | Replaced local Corti import with corti package, hoisted browserSupportsPolyfills mock, removed vendor references |
| package.json | Added corti dependency and bumped Vitest and coverage-v8 versions |
Comments suppressed due to low confidence (1)
src/SpeechRecognition.test.js:265
- A large block of tests related to transcript and continuous listening behaviors was removed; ensure critical scenarios (e.g., interim transcripts, command callbacks) are still covered by other tests to avoid regressions.
test("can set language", async () => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.