Compulsively optimize async calls #80
Open
+122
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleBrownCS
approved these changes
Feb 7, 2020
Contributor
KyleBrownCS
left a comment
KyleBrownCS
left a comment
There was a problem hiding this comment.
Didn't run it to test, but looks good
James-Firth
reviewed
Feb 8, 2020
Owner
James-Firth
left a comment
James-Firth
left a comment
There was a problem hiding this comment.
Looks good just needs a manual test on the live deployment :)
James-Firth
requested changes
Feb 10, 2020
Owner
James-Firth
left a comment
James-Firth
left a comment
There was a problem hiding this comment.
Looks like something wasn't working :(
src/lib/slack/common.js
Outdated
| async function generateAndSendBootMessage(channel = null, { msgText = null } = {}) { | ||
| const { available, benched } = await users.listAllUserNamesByAvailability(); | ||
| const SHA = await simpleGit.revparse(['HEAD']); | ||
| const [{ availableUsers, benchedUsers }, SHA] = await Promise.all([ |
Owner
There was a problem hiding this comment.
I think there's an edge-case here.
it generated the initial boot message fine but then admins saying overview was giving an empty list back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collapse async calls to run concurrently where possible.