Skip to content

fix: Properly render i18n translations client-side#139

Merged
baptistegrimaud merged 2 commits intomainfrom
fix-i18n-client-side
Feb 6, 2026
Merged

fix: Properly render i18n translations client-side#139
baptistegrimaud merged 2 commits intomainfrom
fix-i18n-client-side

Conversation

@baptistegrimaud
Copy link
Copy Markdown
Collaborator

@baptistegrimaud baptistegrimaud commented Feb 5, 2026

Closes Jahia/javascript-modules#317.

Description

Following the change in Jahia/javascript-modules#629, use useTranslation() hook to correctly render i18n translations client-side.

Tip

Documentation to guide the reviews: How to do a code review

@baptistegrimaud baptistegrimaud marked this pull request as ready for review February 5, 2026 09:03
@baptistegrimaud baptistegrimaud requested a review from a team as a code owner February 5, 2026 09:03
@baptistegrimaud baptistegrimaud enabled auto-merge (squash) February 5, 2026 09:15
@baptistegrimaud baptistegrimaud merged commit 9581422 into main Feb 6, 2026
8 checks passed
@baptistegrimaud baptistegrimaud deleted the fix-i18n-client-side branch February 6, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple JS modules on the same page will create conflicting i18next instances

2 participants