refactor: rollup to rolldown, vite 7 to vite 8#668
Conversation
🦜 Chachalog
|
Migrated build pipelines and test suites to Vite 8 and Rolldown for JS Modules compatibility.
There was a problem hiding this comment.
Pull request overview
This PR migrates the JavaScript module build tooling from Rollup/Vite 7 to Rolldown/Vite 8 and updates fixture snapshots to match the new bundler output.
Changes:
- Replaces Rollup/pkgroll build tooling with Rolldown/tsdown.
- Updates Vite dependencies to
^8.0.14across packages and fixtures. - Refreshes fixture build snapshots for generated JS, source maps, and CSS.
Reviewed changes
Copilot reviewed 10 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Updates dependency graph for Vite 8, Rolldown, tsdown, and related transitive packages. |
vite-plugin/src/multi-entry.ts |
Switches plugin typing from Rollup to Rolldown. |
vite-plugin/src/insert-filename.ts |
Switches plugin typing from Rollup to Rolldown and removes the Rollup AST cast. |
vite-plugin/package.json |
Updates build output exports and replaces pkgroll/Rollup with tsdown/Rolldown. |
vite-plugin/fixtures/vite.config.js |
Removes the Vite inspect plugin from fixture builds. |
vite-plugin/fixtures/package.json |
Updates fixture Vite dependency to Vite 8 and removes inspect plugin dependency. |
vite-plugin/fixtures/expected/server/index.js.map |
Refreshes expected server sourcemap output. |
vite-plugin/fixtures/expected/server/index.js |
Refreshes expected server bundle output. |
vite-plugin/fixtures/expected/client/foo.client.tsx.js |
Refreshes expected client bundle output. |
vite-plugin/fixtures/expected/assets/style.css |
Refreshes expected CSS output. |
samples/hydrogen/package.json |
Updates sample Vite dependency to Vite 8. |
javascript-modules-engine/rolldown.config.mjs |
Reworks engine bundling configuration for Rolldown. |
javascript-modules-engine/package.json |
Replaces Rollup scripts and dev dependencies with Rolldown. |
jahia-test-module/package.json |
Updates test module Vite dependency to Vite 8. |
Files not reviewed (3)
- vite-plugin/fixtures/expected/assets/style.css: Language not supported
- vite-plugin/fixtures/expected/client/foo.client.tsx.js: Language not supported
- vite-plugin/fixtures/expected/server/index.js: Language not supported
|
Blocked by rolldown/rolldown#9589 |
Description
No functional changes for external consumers!
This PR evolves our JS build pipeline from rollup to rolldown and vite 7 to vite 8
It should be faster to install and build, and tests now run on the latest version of vite to ensure it works
The large negative diff comes from a lot of dependencies removed, not from my changes
Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review