Skip to content

refactor: rollup to rolldown, vite 7 to vite 8#668

Merged
GauBen merged 6 commits into
mainfrom
refactor-rollup-to-rolldown
May 28, 2026
Merged

refactor: rollup to rolldown, vite 7 to vite 8#668
GauBen merged 6 commits into
mainfrom
refactor-rollup-to-rolldown

Conversation

@GauBen
Copy link
Copy Markdown
Member

@GauBen GauBen commented May 27, 2026

Description

No functional changes for external consumers!

This PR evolves our JS build pipeline from rollup to rolldown and vite 7 to vite 8

It should be faster to install and build, and tests now run on the latest version of vite to ensure it works

The large negative diff comes from a lot of dependencies removed, not from my changes

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

Copilot AI review requested due to automatic review settings May 27, 2026 13:24
@GauBen GauBen requested a review from a team as a code owner May 27, 2026 13:24
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 27, 2026

🦜 Chachalog

javascript-modules patch

Create a new entry online or run npx chachalog@0.5.1 prompt to create a new entry locally.

Migrated build pipelines and test suites to Vite 8 and Rolldown for JS Modules compatibility.
@GauBen GauBen changed the title refactor: rollupto rolldown, vite 7 to vite 8 refactor: rollup to rolldown, vite 7 to vite 8 May 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the JavaScript module build tooling from Rollup/Vite 7 to Rolldown/Vite 8 and updates fixture snapshots to match the new bundler output.

Changes:

  • Replaces Rollup/pkgroll build tooling with Rolldown/tsdown.
  • Updates Vite dependencies to ^8.0.14 across packages and fixtures.
  • Refreshes fixture build snapshots for generated JS, source maps, and CSS.

Reviewed changes

Copilot reviewed 10 out of 15 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
yarn.lock Updates dependency graph for Vite 8, Rolldown, tsdown, and related transitive packages.
vite-plugin/src/multi-entry.ts Switches plugin typing from Rollup to Rolldown.
vite-plugin/src/insert-filename.ts Switches plugin typing from Rollup to Rolldown and removes the Rollup AST cast.
vite-plugin/package.json Updates build output exports and replaces pkgroll/Rollup with tsdown/Rolldown.
vite-plugin/fixtures/vite.config.js Removes the Vite inspect plugin from fixture builds.
vite-plugin/fixtures/package.json Updates fixture Vite dependency to Vite 8 and removes inspect plugin dependency.
vite-plugin/fixtures/expected/server/index.js.map Refreshes expected server sourcemap output.
vite-plugin/fixtures/expected/server/index.js Refreshes expected server bundle output.
vite-plugin/fixtures/expected/client/foo.client.tsx.js Refreshes expected client bundle output.
vite-plugin/fixtures/expected/assets/style.css Refreshes expected CSS output.
samples/hydrogen/package.json Updates sample Vite dependency to Vite 8.
javascript-modules-engine/rolldown.config.mjs Reworks engine bundling configuration for Rolldown.
javascript-modules-engine/package.json Replaces Rollup scripts and dev dependencies with Rolldown.
jahia-test-module/package.json Updates test module Vite dependency to Vite 8.
Files not reviewed (3)
  • vite-plugin/fixtures/expected/assets/style.css: Language not supported
  • vite-plugin/fixtures/expected/client/foo.client.tsx.js: Language not supported
  • vite-plugin/fixtures/expected/server/index.js: Language not supported

Comment thread jahia-test-module/package.json
@GauBen
Copy link
Copy Markdown
Member Author

GauBen commented May 27, 2026

Blocked by rolldown/rolldown#9589

@GauBen GauBen merged commit 05587c5 into main May 28, 2026
15 checks passed
@GauBen GauBen deleted the refactor-rollup-to-rolldown branch May 28, 2026 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants