fix: wait for the configuration to activate GraalVMEngine#635
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent GraalVMEngine (and downstream consumers like ViewsRegistrar) from being activated/refreshed before required OSGi configuration is available, and adds lifecycle logging to help diagnose service unregister/re-register timing issues.
Changes:
- Require OSGi configuration before activating
GraalVMEngine(configurationPolicy = REQUIRE). - Add INFO lifecycle logs for
GraalVMEngineandViewsRegistraractivation/deactivation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/registrars/ViewsRegistrar.java | Adds activation/deactivation INFO logs to trace when the registrar is installed/removed. |
| javascript-modules-engine-java/src/main/java/org/jahia/modules/javascript/modules/engine/jsengine/GraalVMEngine.java | Delays DS activation until configuration is present and adds INFO logs for lifecycle visibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...e-java/src/main/java/org/jahia/modules/javascript/modules/engine/jsengine/GraalVMEngine.java
Show resolved
Hide resolved
...e-java/src/main/java/org/jahia/modules/javascript/modules/engine/jsengine/GraalVMEngine.java
Show resolved
Hide resolved
...e-java/src/main/java/org/jahia/modules/javascript/modules/engine/jsengine/GraalVMEngine.java
Show resolved
Hide resolved
...e-java/src/main/java/org/jahia/modules/javascript/modules/engine/jsengine/GraalVMEngine.java
Show resolved
Hide resolved
...ava/src/main/java/org/jahia/modules/javascript/modules/engine/registrars/ViewsRegistrar.java
Show resolved
Hide resolved
...ava/src/main/java/org/jahia/modules/javascript/modules/engine/registrars/ViewsRegistrar.java
Show resolved
Hide resolved
...ava/src/main/java/org/jahia/modules/javascript/modules/engine/registrars/ViewsRegistrar.java
Show resolved
Hide resolved
baptistegrimaud
approved these changes
Feb 9, 2026
Contributor
baptistegrimaud
left a comment
There was a problem hiding this comment.
LGTM!
Hopefully that'll do it 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/Jahia/jahia-private/issues/4126
Description
Attempt to fix the following error:
This issue happens because at the time the
ViewsRegistraris read by one of its consumer, it has been removed from the OSGi service registry.One culprit could be the configuration that operates a refresh of
ViewsRegistrardependency if detected after the service started, unregistering the service while being read by another process.Logs have been added to identify the source of the error in case it happen again.
the log are useful information that can remain even if the issue won't appear.
Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review