fix(create-module): add missing namespaces#628
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds missing JCR (Java Content Repository) namespace declarations to the create-module archetype template to ensure completeness and consistency with standard JCR specifications.
Changes:
- Added four common JCR namespace declarations (nt, mix, jcr, j) to the definitions.cnd template
- Added a comment to clarify module-specific namespaces
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgriffon
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add common JCR namespaces to the create-module/archetype
Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review