fix: Add required chromeinspector lib for debugging#627
fix: Add required chromeinspector lib for debugging#627baptistegrimaud merged 2 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the required chromeinspector library to enable debugging functionality in the GraalVM engine. The library was previously removed but is necessary for the inspector instrument to work properly.
Changes:
- Added
chromeinspectordependency to both parent and engine module POMs - Added comprehensive test coverage for enabling the GraalVM debugger on different ports
- Added support for testing the debugger on an additional port (10229)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Added chromeinspector dependency declaration in parent POM |
| javascript-modules-engine/pom.xml | Added chromeinspector dependency and embedded it in the OSGi bundle |
| tests/docker-compose.yml | Exposed additional port 10229 for debugger testing |
| tests/cypress/fixtures/graphql/enableGraalVMDebugger.graphql | Added GraphQL mutation for configuring GraalVM debugger settings |
| tests/cypress/e2e/engine/graalvmEngineTest.cy.ts | Added comprehensive test suite for GraalVM debugger functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgriffon
left a comment
There was a problem hiding this comment.
Do we want to document how to enable the JS debugging?
There is already this page on the Academy. |
Academy is ok, thank you! :) |
Fixes #626.
Description
Following #556, the
chromeinspector-<version>.jarlibrary was no longer available but it is required to enable debugging.Without it, it failed with:
The important class of that library is https://github.com/oracle/graal/blob/d018a8910cf09bcaade5cbb62e66e317f15c9871/tools/src/com.oracle.truffle.tools.chromeinspector/src/com/oracle/truffle/tools/chromeinspector/instrument/InspectorInstrument.java#L78.
Tip
Documentation to guide the reviews: How to do a code review