chore: add new prop buttonTextStyle to style default button text#264
Open
manuelbieh wants to merge 2 commits intoJacse:masterfrom
Open
chore: add new prop buttonTextStyle to style default button text#264manuelbieh wants to merge 2 commits intoJacse:masterfrom
manuelbieh wants to merge 2 commits intoJacse:masterfrom
Conversation
|
@Jacse can you merge this small but important MR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey. First of all, great package! I was able to build a really nice looking onboarding screen for my app in no time. The issue I had, however, was that I am using a very light gray as background color so the default white button text was hardly visible. Since I did not want to define and style my own button component for all 4 button types using the
renderXyzButtonprop, I added a new and optionalbuttonTextStyleprop.In my case it allowed me to simply change the text color with a very simple:
Would love to see it merged but I'm open to discussing alternative approaches or any changes you'd like to see 🙂