fix: broaden commit signing language from GPG-only to all methods#154
fix: broaden commit signing language from GPG-only to all methods#154JacobPEvans merged 2 commits intomainfrom
Conversation
Copilot cloud agent now signs commits natively (2026-04-03 changelog). Update PR templates, CONTRIBUTING.md, and README to say "signed" instead of "GPG signed" since GitHub supports GPG, SSH, S/MIME, and native app signing. Add callout in CONTRIBUTING.md noting automated PRs (Copilot, Renovate, GitHub Actions) sign commits automatically. (claude)
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the project's documentation and pull request templates to adopt more inclusive language regarding commit signing. By shifting from 'GPG-signed' to 'Signed', the project now correctly acknowledges modern, automated signing methods supported by GitHub, ensuring the requirements remain accurate as the development workflow evolves. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. The GPG lock was once the key, But now the gates are wide and free. With SSH or native sign, Our commits now all align. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Broadens repository guidance from “GPG-signed commits” to “signed commits” to reflect GitHub’s multiple supported commit-signing methods and to accommodate automated tooling signatures.
Changes:
- Updated README and PR templates to require “Signed commits” instead of “GPG-signed commits”.
- Updated CONTRIBUTING commit-signing guidance to acknowledge automated PR signing via GitHub app/native signing.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates PR template requirements summary to “Signed commits”. |
| docs/CONTRIBUTING.md | Broadens commit-signing language and adds note about automated PR signing. |
| .github/PULL_REQUEST_TEMPLATE/refactor.md | Replaces “GPG signed” checklist item with “signed”. |
| .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | Replaces “GPG signed” checklist item with “signed”. |
| .github/PULL_REQUEST_TEMPLATE/performance.md | Replaces “GPG signed” checklist item with “signed”. |
| .github/PULL_REQUEST_TEMPLATE/feature.md | Replaces “GPG signed” checklist item with “signed”. |
| .github/PULL_REQUEST_TEMPLATE/docs.md | Replaces “GPG signed” checklist item with “signed”. |
| .github/PULL_REQUEST_TEMPLATE/bug.md | Replaces “GPG signed” checklist item with “signed”. |
| .github/PULL_REQUEST_TEMPLATE/breaking.md | Replaces “GPG signed” checklist item with “signed”. |
Comments suppressed due to low confidence (1)
docs/CONTRIBUTING.md:56
- The new wording broadens commit signing beyond GPG, but the “Human Contributors — Getting Started” steps still describe only generating/configuring a GPG key. This reads as if GPG is still the required method. Consider updating this section to explicitly list the supported signing options (GPG / SSH / S/MIME) and link to GitHub’s commit signature verification docs for each, or rephrase the steps as one possible path (GPG) among others.
### Human Contributors — Getting Started
If you've never signed commits before, don't worry—it only takes a few minutes to set up:
1. **Generate a GPG key** (if you don't have one): Follow [GitHub's guide on generating a GPG key](https://docs.github.com/en/authentication/managing-commit-signature-verification/generating-a-new-gpg-key)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
All commits are GPG signed→All commits are signedGPG-signed commits→Signed commitsGitHub now supports GPG, SSH, S/MIME, and native app signing. Copilot cloud agent
started signing commits on 2026-04-03.
The old "GPG signed" language was overly specific and excluded valid signing methods.
These are org-wide inherited defaults — changes propagate to all repos without overrides.
Closes JacobPEvans/ai-workflows#126
Test plan
🤖 Generated with Claude Code