Skip to content

Chore(deps): Bump jablib/src/main/resources/csl-locales from 92e9e22 to 50e46eb#14677

Merged
koppor merged 3 commits intomainfrom
dependabot/submodules/jablib/src/main/resources/csl-locales-50e46eb
Jan 12, 2026
Merged

Chore(deps): Bump jablib/src/main/resources/csl-locales from 92e9e22 to 50e46eb#14677
koppor merged 3 commits intomainfrom
dependabot/submodules/jablib/src/main/resources/csl-locales-50e46eb

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Dec 21, 2025

Bumps jablib/src/main/resources/csl-locales from 92e9e22 to 50e46eb.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jablib/src/main/resources/csl-locales](https://github.com/citation-style-language/locales) from `92e9e22` to `50e46eb`.
- [Release notes](https://github.com/citation-style-language/locales/releases)
- [Commits](citation-style-language/locales@92e9e22...50e46eb)

---
updated-dependencies:
- dependency-name: jablib/src/main/resources/csl-locales
  dependency-version: 50e46eb99b4f0b0a77b48e9a5604624247b46379
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file submodules Pull requests that update submodules code labels Dec 21, 2025
@koppor koppor enabled auto-merge December 21, 2025 14:02
jabref-machine
jabref-machine previously approved these changes Dec 21, 2025
@Siedlerchr
Copy link
Copy Markdown
Member

There now seems to be a comma

@koppor
Copy link
Copy Markdown
Member

koppor commented Dec 23, 2025

Test org.jabref.logic.openoffice.oocsltext.CSLFormatUtilsTest needs to be executed and adapted. @jetbrains-junie

@jetbrains-junie
Copy link
Copy Markdown
Contributor

Hey, it’s Junie by JetBrains! I started processing your request 🚀

@subhramit
Copy link
Copy Markdown
Member

subhramit commented Dec 23, 2025

There now seems to be a comma

They will probably change this again. The comma does not make sense here, and there is an unnecessary whitespace before the period now:
Williams Jeff, . Title

We shall adapt anyway #14706

Pushed to this PR itself.

jabref-machine
jabref-machine previously approved these changes Dec 23, 2025
// Semicolons
Arguments.of(
"1. Smith B, Jones B, Williams J. Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 July;34(3):45–67. Available from: https://github.com/JabRef<p></p>",
"1. Smith B, Jones B, Williams J, . Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 July;34(3):45–67. Available from: https://github.com/JabRef<p></p>",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

loool - CLS bug - we should report maybe?

Copy link
Copy Markdown
Member

@Siedlerchr Siedlerchr Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think @ThiloteE knows how do to this. Which style is this? Or do we need to adapt our handling?
some changed field names?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vancouver
Acta Anaesthesiologica Taiwanica

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we should switch to a more "prominent" one? Chicago?

Copy link
Copy Markdown
Member

@subhramit subhramit Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each test here has some significance
This one was for semicolons, which is absent in Chicago:

Arguments.of(
                        "Smith, Bill, Bob Jones, and Jeff Williams. 2016. “Title of the Test Entry.” <i>BibTeX Journal</i> 34 (3): 45–67. https://doi.org/10.1001/bla.blubb.<p></p>",
                        STYLE_LIST.stream().filter(e -> "Chicago Manual of Style 17th edition (author-date)".equals(e.getTitle())).findAny().get()
                ),

(This testcase is also present, just above this one^)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, they have also changed prominent styles before - IEEE and APA
IEEE: https://github.com/JabRef/jabref/pull/13465/changes

@Siedlerchr Siedlerchr disabled auto-merge December 23, 2025 20:06
@Siedlerchr Siedlerchr removed the dependencies Pull requests that update a dependency file label Dec 23, 2025
Copy link
Copy Markdown
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clarificatio needed

@github-actions github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 23, 2025
@Siedlerchr Siedlerchr enabled auto-merge December 25, 2025 09:36
@Siedlerchr Siedlerchr disabled auto-merge December 25, 2025 09:36
@Siedlerchr Siedlerchr force-pushed the dependabot/submodules/jablib/src/main/resources/csl-locales-50e46eb branch from 4e6fea1 to 51ca6a5 Compare January 6, 2026 19:46
@koppor koppor enabled auto-merge January 6, 2026 19:46
…es/jablib/src/main/resources/csl-locales-50e46eb

* upstream/main: (119 commits)
  chore(sbom): update CycloneDX SBOM files (#14813)
  Add "preferences" constant to ServiceLocator initialization (#14810)
  adjust bom generation to only use runtime (#14809)
  Remove (nearly) obsolete hint in ghprcomment.yml
  Update dependency org.apache.commons:commons-lang3 to v3.20.0 (#14808)
  Fix Nullwarnings - B (#14802)
  Add https
  Add ouput
  Fix stale (again)
  Fix output
  Fix re-downloading of ltwa file
  Chore(deps): Bump jablib/src/main/resources/csl-styles from `9bb1fc1` to `0201999` (#14796)
  Chore(deps): Bump org.ow2.asm:asm from 9.9 to 9.9.1 in /versions (#14799)
  Chore(deps): Bump org.controlsfx:controlsfx in /versions (#14800)
  Chore(deps): Bump org.postgresql:postgresql in /versions (#14798)
  Chore(deps): Bump jablib/src/main/abbrv.jabref.org (#14795)
  Chore(deps): Bump org.apache.logging.log4j:log4j-to-slf4j in /versions (#14797)
  Chore(deps): Bump org.apache.commons:commons-text from 1.14.0 to 1.15.0 in /versions (#14801)
  fix postgres for arm (#14792)
  Docs: minor grammar and clarity fixes in privacy policy (#14786)
  ...
@JabRef JabRef deleted a comment from jetbrains-junie Bot Jan 6, 2026
@dependabot @github
Copy link
Copy Markdown
Contributor Author

dependabot Bot commented on behalf of github Jan 11, 2026

A newer version of jablib/src/main/resources/csl-locales exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@Siedlerchr
Copy link
Copy Markdown
Member

hope this works now with latest citeproc update

@koppor koppor added this pull request to the merge queue Jan 12, 2026
Merged via the queue into main with commit e450112 Jan 12, 2026
54 checks passed
@koppor koppor deleted the dependabot/submodules/jablib/src/main/resources/csl-locales-50e46eb branch January 12, 2026 03:45
Siedlerchr added a commit to st-rm-ng/jabref that referenced this pull request Jan 17, 2026
* upstream/main: (64 commits)
  New Crowdin updates (JabRef#14862)
  Make JDK25 available (JabRef#14861)
  Fix empty entries array when exporting group chat to JSON (JabRef#14814)
  feat: add right-click copy context menu to AI chat messages (JabRef#14722)
  FIX : generic error dialog and icon in Source Tab parsing (JabRef#14828)
  Factor out setup-* actions (JabRef#14859)
  Link .http files.
  Update dependency org.postgresql:postgresql to v42.7.9 (JabRef#14857)
  Add more commands to JabSrv (JabRef#14855)
  Fix JabRef#14821: Hide identifier action buttons when field is empty (JabRef#14831)
  Add GH_TOKEN to closed issues/PRs processing step
  New Crowdin updates (JabRef#14854)
  New Crowdin updates (JabRef#14849)
  Chore(deps): Bump jablib/src/main/resources/csl-styles from `0201999` to `f345aa8` (JabRef#14833)
  Add support for book front covers, again (JabRef#14777)
  Readd min width to button in new enty dialog (JabRef#14791)
  Replace plugin impl from jbang plugin (JabRef#14846)
  Revise AI policy wording
  Chore(deps): Bump jablib/src/main/resources/csl-locales (JabRef#14677)
  Update dependency com.konghq:unirest-modules-gson to v4.7.1 (JabRef#14845)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: changes-required Pull requests that are not yet complete submodules Pull requests that update submodules code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants