feat(citation): add support for selecting citation fetcher in Citatio… by Siva-Sai22 · Pull Request #14652 · JabRef/jabref

Siva-Sai22 · 2025-12-18T11:25:39Z

Introduce CitationFetcherFactory and CitationFetcherType for managing fetcher selection
Add dropdown in CitationRelationsTab to choose between Semantic Scholar and CrossRef fetchers
Persist selected fetcher in EntryEditorPreferences
Update SearchCitationsRelationsService and related classes to use selected fetcher
Refactor CrossRefCitationFetcher to standardize fetcher name

Steps to test

Add a lib entry
Go to the citations tab to see the new drop down menu.

Mandatory checks

I own the copyright of the code submitted and I license it under the MIT license
I manually tested my changes in running JabRef (always required)
I added JUnit tests for changes (if applicable)
I added screenshots in the PR description (if change is visible to the user)
I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

…nRelationsTab - Introduce CitationFetcherFactory and CitationFetcherType for managing fetcher selection - Add dropdown in CitationRelationsTab to choose between Semantic Scholar and CrossRef fetchers - Persist selected fetcher in EntryEditorPreferences - Update SearchCitationsRelationsService and related classes to use selected fetcher - Refactor CrossRefCitationFetcher to standardize fetcher name

github-actions · 2025-12-20T03:29:59Z

Your pull request conflicts with the target branch.

Please merge with your code. For a step-by-step guide to resolve merge conflicts, see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-using-the-command-line.

koppor · 2025-12-20T13:48:08Z

+        fetcherCombo.getSelectionModel().selectedItemProperty().addListener((observable, oldValue, newValue) -> {
+            if (newValue != null) {
+                // Cancel any running searches so they don't continue with the old fetcher
+                if (citingTask != null && !citingTask.isCancelled()) {


Does this variable have a @Nullable annotation?

No it doesn't have.

https://github.com/JabRef/jabref/blob/3a721047b859eda99c03cc3a365d29e428566ada/jabgui/src/main/java/org/jabref/gui/entryeditor/citationrelationtab/CitationRelationsTab.java#L708C9-L712C10

For this I took reference from the above code

What I meant with the comment: Either mark the variable as @Nullable or remove the null check.

Currently, I don't see when a user can select null

Yeah removed the null check

…ieving EntryEditorPreferences from preferences

koppor

Some architecture comments.

Update following is not related to this pr - And also a runtime issue

koppor · 2025-12-23T10:19:38Z

+        fetcherCombo.getSelectionModel().selectedItemProperty().addListener((observable, oldValue, newValue) -> {
+            if (newValue != null) {
+                // Cancel any running searches so they don't continue with the old fetcher
+                if (citingTask != null && !citingTask.isCancelled()) {


Currently, I don't see when a user can select null

koppor · 2025-12-23T11:26:01Z

@Siva-Sai22 Do you have time today to finish this? Would be nice to have it in the release :)

Siva-Sai22 · 2025-12-23T11:46:43Z

@koppor Yeah just updating the changes. Will raise the pr in an hour.

koppor · 2025-12-23T11:49:01Z

@koppor Yeah just updating the changes. Will raise the new pr in an hour.

No new PR, just push to your branch fix/#14430

Siva-Sai22 · 2025-12-23T12:06:41Z

yeah to this pr only

…d service - Expose citationFetcherTypeProperty in EntryEditorPreferences for property binding - Update CitationRelationsTab to use property binding for fetcher selection and remove default fallback - Refactor SearchCitationsRelationsService to subscribe to citationFetcherType changes via property binding, removing manual fetcher switching logic - Simplify CitationFetcherType by removing unreachable default case

Siva-Sai22 · 2025-12-26T10:11:36Z

@koppor actually I was travelling to my home from college. Sorry for that will implement it

koppor · 2025-12-27T23:38:33Z

        return entry
                .getDOI()
-                .map(doi -> relationsMap.getOrDefault(doi.asString(), new LinkedHashSet<>()).stream().toList())
+                .map(doi -> relationsMap.getOrDefault(doi.asString() + citationFetcherPropertyType.get().getName(), new LinkedHashSet<>()).stream().toList())


@calixtus This is not clean, but works. I would do that refactoring as follow-up.

calixtus · 2025-12-28T21:01:47Z

+public enum CitationFetcherFactory {
+    INSTANCE;
+
+    public CitationFetcher getCitationFetcher(CitationFetcherType citationFetcherName,
+                                              ImporterPreferences importerPreferences,
+                                              ImportFormatPreferences importFormatPreferences,
+                                              CitationKeyPatternPreferences citationKeyPatternPreferences,
+                                              GrobidPreferences grobidPreferences,
+                                              AiService aiService) {
+        return switch (citationFetcherName) {
+            case CROSSREF ->
+                    new CrossRefCitationFetcher(importerPreferences, importFormatPreferences,
+                            citationKeyPatternPreferences, grobidPreferences, aiService);
+            case SEMANTIC_SCHOLAR ->
+                    new SemanticScholarCitationFetcher(importerPreferences);
+        };
+    }
+}


I have the strong feeling that this Singleton is completly faulty.

github-actions Bot added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Dec 18, 2025

koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 18, 2025

koppor mentioned this pull request Dec 18, 2025

feat(citation): add support for selecting citation fetcher in CitationRelationsTab #14650

Closed

6 tasks

Merge branch 'JabRef:main' into fix/JabRef#14430

3dcf695

calixtus added the component: fetcher label Dec 19, 2025

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Dec 20, 2025

Merge branch 'main' into fix/JabRef#14430

20f7b36

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 20, 2025

koppor requested changes Dec 20, 2025

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 20, 2025

Siva-Sai22 and others added 2 commits December 20, 2025 23:02

Merge branch 'JabRef:main' into fix/JabRef#14430

5930a1b

refactor(citation): simplify CitationRelationsTab constructor by retr…

9c3247e

…ieving EntryEditorPreferences from preferences

github-actions Bot added status: changes-required Pull requests that are not yet complete and removed status: changes-required Pull requests that are not yet complete labels Dec 20, 2025

Siva-Sai22 and others added 2 commits December 23, 2025 15:26

docs(changelog): modified citationRelationTab to citations Tab

65a6d64

Merge branch 'main' into fix/JabRef#14430

02d540b

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 23, 2025

koppor requested changes Dec 23, 2025

View reviewed changes

github-actions Bot added the status: changes-required Pull requests that are not yet complete label Dec 23, 2025

koppor mentioned this pull request Dec 23, 2025

Fix crossRef fetcher #14696

Merged

1 task

Siva-Sai22 added 2 commits December 23, 2025 19:28

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 23, 2025

Merge branch 'main' into fix/JabRef#14430

0250e06

github-actions Bot removed the status: changes-required Pull requests that are not yet complete label Dec 26, 2025

fix(citation): ensure citation relations are stored per fetcher type

ee45597

koppor previously approved these changes Dec 27, 2025

View reviewed changes

koppor added the status: awaiting-second-review For non-trivial changes label Dec 27, 2025

koppor requested a review from calixtus December 27, 2025 23:38

koppor mentioned this pull request Dec 28, 2025

Refine CrossRefCitationFetcher #14743

Merged

1 task