Rearrange argument order in CitationKeyGeneratorTest and convert some MethodSource to CsvSources#14600
Closed
hisunll wants to merge 7 commits intoJabRef:mainfrom
Closed
Rearrange argument order in CitationKeyGeneratorTest and convert some MethodSource to CsvSources#14600hisunll wants to merge 7 commits intoJabRef:mainfrom
hisunll wants to merge 7 commits intoJabRef:mainfrom
Conversation
github-actions
Bot
added
the
status: changes-required
calixtus
added
dev: code-quality
calixtus
changed the title
github-actions
Bot
removed
the
status: changes-required
Siedlerchr
added
the
status: ready-for-review
koppor
requested changes
Dec 23, 2025
Member
koppor
left a comment
koppor
left a comment
There was a problem hiding this comment.
Not sure if you followed other PRs...
Comment on lines
-790
to
-794
| Arguments.of("[keyword1]", "w1"), | ||
| // check keywords with space | ||
| Arguments.of("[keyword2]", "w2aw2b"), | ||
| // check out of range | ||
| Arguments.of("[keyword4]", "") |
Comment on lines
819
to
796
| return Stream.of( | ||
| // all keywords | ||
| Arguments.of("[keywords]", "w1w2aw2bw3"), | ||
| // check keywords with space | ||
| Arguments.of("[keywords2]", "w1w2aw2b"), | ||
| // check out of range | ||
| Arguments.of("[keywords55]", "w1w2aw2bw3") | ||
| Arguments.of("w1w2aw2bw3", "[keywords]"), | ||
| Arguments.of("w1w2aw2b", "[keywords2]"), | ||
| Arguments.of("w1w2aw2bw3", "[keywords55]") | ||
| ); |
github-actions
Bot
added
status: changes-required
Member
|
@hisunll Will you continue here or should we free this for another contributor wanting to learn about high-quality software engineering? |
Author
Thanks for checking in. I won’t be able to continue this in the near term, so please free it up for another contributor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored JabRef#676
We Refactored
CitationKeyGeneratorTestto use csv source instead of method source if possible according to test.md.We are very sorry for not replying quickly enough for the last PR #14133.
Please confirm you want us to do change expected to the first argument because the previous maintainer writes it that way.
Steps to test
./gradlew test --tests CitationKeyGeneratorTestMandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)