Skip to content
This repository was archived by the owner on Sep 20, 2025. It is now read-only.

Conversation

@vitormattos
Copy link

@vitormattos vitormattos commented Aug 4, 2025

to-do

  • updated to newest version of JSignPdf and also of jre
  • implement return typing and add instructions to update
  • Launch a newest release of this package after merge this PR

I updated to newest version of JSignPdf and also of jre

Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
@vitormattos vitormattos requested a review from jeidison August 4, 2025 12:56
@vitormattos vitormattos self-assigned this Aug 4, 2025
@jeidison
Copy link

jeidison commented Aug 4, 2025

@vitormattos Two points:

  1. I believe we only need the JRE, not the JDK.
  2. I suggest implementing a way to select the version at runtime. By default, we can use JRE 21 and JSignPDF 2.3, but it would be good to offer a way to change these versions. What do you think?

@jeidison
Copy link

jeidison commented Aug 4, 2025

@vitormattos Another point: can we download the JRE at download runtime?

I'm not sure if that's possible, but maybe we could remove the JRE from our package and download it at download runtime from an external repository, such as: https://github.com/adoptium/temurin21-binaries/releases

@vitormattos
Copy link
Author

I used the JRE, but the package internally uses files with "JDK" in their names.

In LibreSign, is downloaded a specific JRE and JSignPdf version and set the path of both.

P.S.: In LibreSign, I don't use this package.

We could implement something similar by locking the dependencies to a specific Java and JSignPdf version.

I'll think more about this... If we move in that direction, we might not need this repository anymore.

@vitormattos
Copy link
Author

@jeidison what do you think about setting the URL of files to download and fix the compress engine as .tar.gz that is used by adoptium/temurin21 ? We can do this at the other package side. I can send a PR with this POC.

@vitormattos
Copy link
Author

@jeidison look here the purpose to solve this and remove the dependency of this repository:

JSignPdf/jsignpdf-php#30

@vitormattos
Copy link
Author

@jeidison I think that now we can archive this repository.

@jeidison
Copy link

@jeidison I think that now we can archive this repository.

Yes, we can!

@jeidison jeidison closed this Sep 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants