Skip to content

feat(registry): add SN31 Recall TaoMarketCap candle-chart data-artifact (#4034)#4993

Closed
ultrahighsuper wants to merge 1 commit into
JSONbored:mainfrom
ultrahighsuper:feat/sn31-recall-candle-chart
Closed

feat(registry): add SN31 Recall TaoMarketCap candle-chart data-artifact (#4034)#4993
ultrahighsuper wants to merge 1 commit into
JSONbored:mainfrom
ultrahighsuper:feat/sn31-recall-candle-chart

Conversation

@ultrahighsuper

Copy link
Copy Markdown
Contributor

Summary

Registers SN31 Recall's public OHLCV candle-chart dataset as a data-artifact surface — a no-auth JSON time-series of Recall's alpha-token price/volume, and Recall's first registered public data surface.

Surface

  • kind: data-artifact
  • url: https://api.taomarketcap.com/public/v1/subnets/31/candle-chart/
  • provider: taomarketcap (existing)
  • auth_required: false, public_safe: true, authority: community, review.state: community-submitted

Proof of ownership / authority

  • Recall publishes no verified first-party website/API (its manifest source_repo/website_url/docs_url are all null), so this indexed on-chain feed from api.taomarketcap.com — a provider-claimed on-chain indexer — is the concrete public data surface, the same authority basis accepted for other subnets that lack a first-party host (e.g. the merged SN73 MetaHash candle-chart).
  • source_urls: the TaoMarketCap developer API docs and tensorplex-labs/subnet-docs/data/31/subnet.json (confirms SN31 Recall's identity). The endpoint is listed in TaoMarketCap's public OpenAPI with an optional API key (no-auth access supported).

Verified live + public + safe

  • GET https://api.taomarketcap.com/public/v1/subnets/31/candle-chart/HTTP 200, application/json, ~223 KB, no auth.
  • Real payload: an array of hourly OHLCV candles, each scoped to subnet_id: 31, with period_name, timestamp, block_number, open/high/low/close, volume, start_volume, tao_price_usd/eur.
  • Public-safe: scanned the full body for SS58/base58 wallet or hotkey strings → zero matches; price/volume time-series only.

Non-duplication

Recall's manifest currently has no surfaces; this is its first, and no open PR targets SN31.

Scope note (relative to #4034)

#4034 asks for SN31 Recall's public data artifact. This standalone, machine-readable OHLCV price/volume dataset is exactly that.

Validation (local)

  • npm run validate:surface -- registry/subnets/recall.json → passes (1 surface)
  • npm run scan:public-safety → passes
  • npm run validate:schemas → passes
  • npx prettier --check registry/subnets/recall.json → clean
  • git diff --stat → single file, appends one community surface (no top-level metadata touched)

Template Used

  • Subnet surface

Closes #4034

@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.94%. Comparing base (9a55b6f) to head (3cf1c4e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4993   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files         163      163           
  Lines       19440    19440           
  Branches     7385     7385           
=======================================
  Hits        19040    19040           
  Misses         53       53           
  Partials      347      347           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot added gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier. Reserved for outstanding work. labels Jul 12, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review result - fixes required

Review updated: 2026-07-12 22:43:46 UTC

1 file · 2 AI reviewers · no blockers · readiness 100/100 · CI failing · unstable

🛑 Suggested Action - Fix Blockers

Review summary
This is a single-file, append-only surface addition to registry/subnets/recall.json, adding a data-artifact for SN31's TaoMarketCap OHLCV candle-chart endpoint. Recall has no existing surfaces and no first-party website/API, so this is consistent with the accepted pattern used for MetaHash (SN73) with the same provider and endpoint shape. The manifest netuid (31) matches the linked issue #4034, review.state is correctly community-submitted, and no top-level subnet metadata was touched.

Nits — 5 non-blocking
  • The failing `test` CI check is not explained in the diff or description — confirm it's unrelated to this change (e.g. a pre-existing/flaky failure) before merge.
  • source_urls point to generic TaoMarketCap docs and the subnet-docs identity file rather than a page that explicitly names/lists this specific candle-chart endpoint; worth double-checking the docs page actually documents this exact path.
  • Verify the failing `test` job in CI isn't caused by this PR (e.g. schema validation) even though it wasn't flagged as a blocker here.
  • Consider linking directly to the OpenAPI spec section (if any) documenting the /candle-chart endpoint for stronger source_url proof.
  • `registry/subnets/recall.json:58` uses the generic TaoMarketCap documentation landing page as source evidence; if an exact OpenAPI JSON URL or stable operation URL exists, that would make the endpoint proof less dependent on a JavaScript-rendered docs shell.

CI checks failing

  • test
Signal Result Evidence
Code review ✅ No blockers 2 reviewers, synthesized
Linked issue ✅ Linked #4034
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 54 registered-repo PR(s), 26 merged, 20 issue(s).
Contributor context ✅ Confirmed Gittensor contributor ultrahighsuper; Gittensor profile; 54 PR(s), 20 issue(s).
Gate result ✅ Passing No configured blocker found.
Linked issue satisfaction

Addressed
The PR touches exactly registry/subnets/recall.json and appends a data-artifact surface with a real, verifiable no-auth URL, source_urls proving the subnet mapping, provider taomarketcap, public_safe true, and authority community — matching the issue's submission format and rules.

Review context
  • Author: ultrahighsuper
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 54 PR(s), 20 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Keep the PR focused and include validation evidence before maintainer review.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb

Copy link
Copy Markdown
Contributor

Gittensory is closing this pull request on the maintainer's behalf (CI is failing (test)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

@gittensory-orb gittensory-orb Bot closed this Jul 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier. gittensor:priority Maintainer-selected Gittensor priority — scores a 1.5x multiplier. Reserved for outstanding work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enrich SN31 Recall — add public data artifact

1 participant