fix(ui): flag the incident strip's scope when it reports a different subnet (#3951)#4943
fix(ui): flag the incident strip's scope when it reports a different subnet (#3951)#4943real-venus wants to merge 1 commit into
Conversation
…subnet The global incident strip surfaces the network's single top active incident on every /subnets and /endpoints route, but on a subnet detail page it gave no signal when that incident concerned a DIFFERENT subnet — so "Degraded … SN10" rendered directly above SN1's masthead read as SN1's own status (JSONbored#3951). Derive the current subnet from the path and, when the incident's subject differs (another subnet, or a non-subnet network-wide notice), render an explicit scope chip ("Other subnet" / "Network-wide") next to the severity label so the banner can't be misread as the current page's health. Closes JSONbored#3951
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4943 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 163 163
Lines 19460 19460
Branches 7373 7373
=======================================
Hits 19060 19060
Misses 53 53
Partials 347 347 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-13 00:33:37 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 7 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
left a comment
There was a problem hiding this comment.
Please use the AI skill in the repo when submitting screenshot - it includes instructions for your AI harness to handle the capture and inclusion of this evidence in the exact image sizes / format / layout necessary.
Your images look manually captured and include browser devtools panels, which makes reviewing your changes much harder and far more time consuming, since I can't just tab back/forth between each before and after image, and the images are different sizes so visually, it's much harder for eyes to detect small changes or issues easily.
TL:DR - it makes reviews take a lot longer and more frustrating.
I updated the PR description. |
|
Please kindly review this. |
Summary
Closes #3951
The global incident strip surfaces the network's single top active incident on every
/subnetsand/endpointsroute, but on a subnet detail page it gave no signal when that incident concerned a different subnet — so "Degraded … SN10"rendering directly above SN1's masthead read as SN1's own status (#3951).
This derives the current subnet from the path and, when the incident's subject differs (another subnet, or a non-subnet network-wide notice), renders an explicit scope chip ("Other subnet" / "Network-wide") next to the severity label, so the banner can't be misread as the current page's health.
Changes
components/metagraphed/incident-strip.tsx— computeconcernsOtherEntityfrom the current/subnets/<n>path vs. the incident'snetuid, and render a scope chip when they differ.Screenshots
Incident strip on
/subnets/1while the active incident concerns SN10 (mockedfor a deterministic capture). The only change is the "Other subnet" scope
chip after the "Degraded" label — captured at fixed viewports via Playwright.
before
after
before
after
before
after
before
after
before
after
before
after
Validation
tsc --noEmit✓ ·prettier --check(3.9.4) ✓ ·eslint(0 errors) ✓vitest run— 665/665 pass ✓ ·build✓