fix(ui): let the subnet compare table scroll horizontally on narrow viewports (#3933)#4929
fix(ui): let the subnet compare table scroll horizontally on narrow viewports (#3933)#4929rust-toml wants to merge 1 commit into
Conversation
…iewports (JSONbored#3933) `CompareGrid` wrapped its table in `overflow-auto` but set the table to `w-full`, so the table could never grow past the container — with one column added per compared subnet, the columns were squeezed into a fixed width and the horizontal scrollbar never appeared, hiding data on mobile. Switch the table to `min-w-full` and give each subnet column a `min-w` (with `whitespace-nowrap` headers) so added columns force the table past the container and the existing `overflow-auto` reveals them via horizontal scroll. The Metric column is pinned with `sticky left-0` (over an opaque background) so the row labels stay visible while the value columns scroll. Closes JSONbored#3933
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4929 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 162 162
Lines 19459 19459
Branches 7365 7365
=======================================
Hits 19059 19059
Misses 53 53
Partials 347 347 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-13 00:33:42 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 7 non-blocking
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
JSONbored
left a comment
There was a problem hiding this comment.
Please, submit a GIF and/or recording for each before + after, not static screenshots. The AI skill in the repo should include instructions for your AI harness to accurately handle this.
Update the existing before/after screenshots with the recordings/GIFs in the same format, please (not as a comment on this PR, but in your original PR description, replacing the existing screenshot images).
The PR description has been updated. |

Summary
Closes #3933
The subnet compare drawer's table used
overflow-autoon the wrapper butw-fullon the table, so it could never grow past its container — each added subnet column was squeezed and the horizontal scrollbar never appeared, hiding columns on mobile. This switches the table tomin-w-fullwith a per-columnmin-wso added columns push the table past the container and the existingoverflow-autoreveals them via horizontal scroll; the Metric label column is pinnedsticky left-0so row labels stay visible while values scroll.Gates
typecheck ✓ · unit tests ✓ · prettier ✓ · build ✓ · responsive-overflow e2e ✓
Screenshots
columns clipped, no scroll
readable cards
columns clipped, no scroll
readable cards
table
table, header pinned
table
table, header pinned
table
table, header pinned
table
table, header pinned