docs(settings): clarify moderationGateMode gates only the shared violation tally#5314
Merged
Merged
Conversation
…ation tally The field's JSDoc said "whether the whole layer runs on THIS repo" -- read in isolation this implies "off" disables the anti-abuse system. It does not: the four enforcement mechanisms (contributor-cap close, blacklist close, review-nag cooldown, review-evasion close) each read only their own independent setting and never check this field. Its one real call site runs only after enforcement already completed -- it gates only the shared cross-repo violation tally + warning/ banned label + auto-blacklist-at-threshold. moderation-rules.ts's own file header and .gittensory.yml.example already describe this scope correctly; reworded the types.ts JSDoc to match, and added the same caveat to the openapi occurrence. Docs-only, no behavior change. Regenerated openapi.json. Refs #5289
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | d80bf7e | Commit Preview URL Branch Preview URL |
Jul 12 2026, 01:43 PM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5314 +/- ##
=======================================
Coverage 94.37% 94.37%
=======================================
Files 474 474
Lines 40128 40128
Branches 14631 14631
=======================================
Hits 37869 37869
Misses 1583 1583
Partials 676 676
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`moderationGateMode`'s JSDoc said "whether the whole layer runs on THIS repo" — read in isolation this implies `"off"` disables the anti-abuse system. It does not: the four enforcement mechanisms (contributor-cap close, blacklist close, review-nag cooldown, review-evasion close) each read only their own independent setting and never check this field. Its one real call site (`applyModerationEscalationForRule`) runs only after enforcement already completed — it gates only the shared cross-repo violation tally + warning/banned label + auto-blacklist-at-threshold.
`moderation-rules.ts`'s own file header and `.gittensory.yml.example` already describe this scope correctly — reworded the `types.ts` JSDoc to match, and added the same caveat to the one `openapi/schemas.ts` occurrence.
Scope
Docs-only, no functional code change. `src/types.ts`, `src/openapi/schemas.ts`, regenerated `openapi.json`.
Validation
Closes #5289