Skip to content

docs(engine): document the readinessMode/readinessMinScore engine-layer rename#5309

Merged
gittensory-orb[bot] merged 1 commit into
mainfrom
docs/readiness-mode-rename-comment
Jul 12, 2026
Merged

docs(engine): document the readinessMode/readinessMinScore engine-layer rename#5309
gittensory-orb[bot] merged 1 commit into
mainfrom
docs/readiness-mode-rename-comment

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

`FocusManifestGateConfig`'s `readinessMode`/`readinessMinScore` fold into `RepositorySettings.qualityGateMode`/`qualityGateMinScore` — a third spelling of the same concept the yml-key rename already covers via `check-docs-drift.mjs`'s alias manifest, but undocumented at the engine-layer type itself (unlike its sibling `checkMode` two lines above, which does cross-reference its DB counterpart).

Deliberately did not add a `check-docs-drift.mjs` enforcement entry — that script's own `FOCUS_MANIFEST_SKIP_TOP_LEVEL_FIELDS` comment already documents this exact renaming pattern class as intentionally non-exhaustive. Also skipped mirroring on `predicted-gate-types.ts` — that type comments zero fields (not even its own `checkMode`), so adding one only to `readinessMode` there would be inconsistent with its established style.

Scope

Comment-only, one file.

Validation

  • `npm --workspace @jsonbored/gittensory-engine run build` — clean
  • `npm run typecheck` — clean

Closes #5285

…er rename

FocusManifestGateConfig's readinessMode/readinessMinScore fold into
RepositorySettings.qualityGateMode/qualityGateMinScore -- a third
spelling of the same concept the yml-key rename already covers, but
undocumented at the engine-layer type itself (unlike its sibling
checkMode two lines above, which does cross-reference its DB
counterpart). Comment-only, no behavior change.

Refs #5285
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
gittensory-ui ef17617 Commit Preview URL

Branch Preview URL
Jul 12 2026, 01:39 PM

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 12, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 12, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

Review updated: 2026-07-12 13:42:33 UTC

1 file · 2 AI reviewers · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This is a pure comment addition to `FocusManifestGateConfig` documenting that `readinessMode`/`readinessMinScore` fold into `RepositorySettings.qualityGateMode`/`qualityGateMinScore`, matching the convention set by the sibling `checkMode` field's cross-reference comment two lines above. The change is comment-only, matches its stated scope, and closes the linked issue #5285.

Nits — 5 non-blocking
  • No test coverage is needed here since this is a JSDoc comment addition with zero behavioral change, so the 'zero test-path evidence' flag is expected and not concerning.
  • The comment references `src/signals/focus-manifest.ts` but per the provided context that file is a re-export shim — worth double-checking the `qualityGateMode`/`qualityGateMinScore` mapping actually lives in `src/types.ts` or wherever `RepositorySettings` is defined, not in the shim itself.
  • Consider whether the same cross-reference comment should eventually be added to `predicted-gate-types.ts` for consistency, though the PR description reasonably justifies deferring that given the type's existing zero-comment style.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
  • Code changes lack test evidence — Add focused regression tests or explain why existing coverage is sufficient.
Signal Result Evidence
Code review ✅ No blockers 2 reviewers, synthesized
Linked issue ✅ Linked #5285
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 44 registered-repo PR(s), 36 merged, 476 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 44 PR(s), 476 issue(s).
Gate result ✅ Passing No configured blocker found.
Improvement ⚠️ ℹ️ None detected risk: low · value: none — No structural-improvement signals were detected for this PR. LLM value judgment: minor — The diff is a well-targeted, four-line JSDoc addition that closes a documented gap consistent with an existing sibling-field convention, but it has no functional impact on the codebase.
Linked issue satisfaction

Addressed
The diff adds a doc comment above readinessMode/readinessMinScore in focus-manifest.ts cross-referencing RepositorySettings.qualityGateMode/qualityGateMinScore, matching the requested deliverable and explicitly avoiding a check-docs-drift.mjs entry as required.

Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: not available
  • Official Gittensor activity: 44 PR(s), 476 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask <question> answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit 05e7488 into main Jul 12, 2026
13 checks passed
@gittensory-orb gittensory-orb Bot deleted the docs/readiness-mode-rename-comment branch July 12, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document the engine-layer readinessMode/readinessMinScore rename

1 participant