docs(engine): document the readinessMode/readinessMinScore engine-layer rename#5309
Conversation
…er rename FocusManifestGateConfig's readinessMode/readinessMinScore fold into RepositorySettings.qualityGateMode/qualityGateMinScore -- a third spelling of the same concept the yml-key rename already covers, but undocumented at the engine-layer type itself (unlike its sibling checkMode two lines above, which does cross-reference its DB counterpart). Comment-only, no behavior change. Refs #5285
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | ef17617 | Commit Preview URL Branch Preview URL |
Jul 12 2026, 01:39 PM |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review result - approve/merge recommendedReview updated: 2026-07-12 13:42:33 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
`FocusManifestGateConfig`'s `readinessMode`/`readinessMinScore` fold into `RepositorySettings.qualityGateMode`/`qualityGateMinScore` — a third spelling of the same concept the yml-key rename already covers via `check-docs-drift.mjs`'s alias manifest, but undocumented at the engine-layer type itself (unlike its sibling `checkMode` two lines above, which does cross-reference its DB counterpart).
Deliberately did not add a `check-docs-drift.mjs` enforcement entry — that script's own `FOCUS_MANIFEST_SKIP_TOP_LEVEL_FIELDS` comment already documents this exact renaming pattern class as intentionally non-exhaustive. Also skipped mirroring on `predicted-gate-types.ts` — that type comments zero fields (not even its own `checkMode`), so adding one only to `readinessMode` there would be inconsistent with its established style.
Scope
Comment-only, one file.
Validation
Closes #5285